public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Marquardt <marquardt@codemercs.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Dmitry Torokhov <dtor@insightbb.com>,
	Li Yu <raise.sail@gmail.com>,
	yanghong@ccoss.com.cn,
	linux-usb-devel <linux-usb-devel@lists.sourceforge.net>,
	hongzhiyi@ccoss.com.cn, Marcel Holtmann <marcel@holtmann.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [linux-usb-devel] [RFC] HID bus design overview.
Date: Mon, 02 Apr 2007 12:14:09 +0200	[thread overview]
Message-ID: <4610D771.4020806@codemercs.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0704021134250.3808@jikos.suse.cz>

Jiri Kosina wrote:

> I agree. I am aware of devices for which just inspecting the parsed data 
> would be OK (some keyboards with usage mappings which are not defined by 
> HUT, for example), but also of devices which require special handling on 
> the report level - Robert Marquardt pointed me in a private mail to a few 
> devices which are broken par-excellence, and for which handling on report 
> level would be convenient.
> 
> Also, handling on report level would be nice to have so that we could hook 
> a hidraw driver to it.

Just forgot to use "Reply All".

Here is the text (expanded):
Definitely. I know of several devices where the HID descriptor and the 
data sent completely disagree.
A Metex USB Multimeter for example tells that it has a 4 byte report 
divided into a 3 byte and a 1 byte element. The device sends two reports 
each containing two 2 byte elements with one in the second report not 
containing data.
The wierdest device is a CD archive torus which shows up as a simple 
standard mouse. Commands are sent by *reading* strings.
The Office Rocket Launcher is posing as a keyboard and reacts to the 
LEDs being set (this is of interest for the Num-Lock thread here).
I definitely hope that the latter two devices will never get official 
kernel support in any way.

Why is the report parsed on driver level at all? It should be possible 
to allow drivers to manipulate the reports, but i see no reason to split 
the report into usages that early. The Windows HID API parses the report 
happily in the HID.DLL for user programs. Drivers have the same API 
available on kernel level.
So a raw API for the drivers should be the primary API. It is usually 
easier to manipulate the report directly instead of abstract operations. 
It is also fairly safe. The device has been identified so the offending 
report layout can be presumed. Parsing for specific usages should be 
done from the driver. Preparsing the report before the data is handed to 
the driver only wastes CPU cycles.

  reply	other threads:[~2007-04-02 10:14 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-05  7:32 [DOC] The documentation for HID Simple Driver Interface 0.5.0 Li Yu
2007-03-05 20:44 ` Marcel Holtmann
2007-03-05 20:11   ` Dmitry Torokhov
2007-03-05 22:40     ` Marcel Holtmann
2007-03-06 13:25       ` Dmitry Torokhov
2007-03-06 13:47       ` Jiri Kosina
2007-03-06 18:57         ` Marcel Holtmann
2007-03-05 21:47   ` Jiri Kosina
2007-03-05 22:12 ` [linux-usb-devel] " Jiri Kosina
2007-03-05 22:27   ` Dmitry Torokhov
2007-03-06  1:37     ` Liyu
     [not found]     ` <45ECC5A4.20203@ccoss.com.cn>
2007-03-06  9:40       ` Jiri Kosina
2007-03-06 11:52       ` Harold Sargeant
2007-03-06  7:01   ` Robert Marquardt
2007-03-06  7:37     ` Jiri Kosina
2007-03-19 10:44 ` [RFC] HID bus design overview Li Yu
2007-03-26  8:27   ` [linux-usb-devel] " Marcel Holtmann
2007-03-28  1:58     ` Li Yu
     [not found]     ` <4609CAF2.3040303@ccoss.com.cn>
2007-03-28  7:51       ` Jiri Kosina
2007-03-28 19:00         ` Dmitry Torokhov
2007-03-28 19:13           ` Jiri Kosina
2007-03-30  3:06           ` Li Yu
2007-03-30  4:33             ` Dmitry Torokhov
2007-03-30  5:37               ` Li Yu
2007-03-30 16:13                 ` Dmitry Torokhov
2007-03-31 22:49               ` Jiri Kosina
2007-04-02  1:47                 ` Li Yu
2007-04-02  4:15                   ` Dmitry Torokhov
2007-04-02  7:07                     ` Li Yu
2007-04-02  7:42                       ` Greg KH
2007-04-02  9:34                       ` Jiri Kosina
2007-04-02 12:40                         ` Dmitry Torokhov
2007-04-02  4:09                 ` Dmitry Torokhov
2007-04-02  9:37                   ` Jiri Kosina
2007-04-02 10:14                     ` Robert Marquardt [this message]
2007-04-02 12:21           ` Marcel Holtmann
2007-04-02 12:33             ` Jiri Kosina
2007-04-02 16:47               ` Marcel Holtmann
2007-04-03  1:15                 ` Li Yu
2007-04-03  3:42                   ` Dmitry Torokhov
2007-04-03  8:57                   ` Jiri Kosina
2007-04-04  0:55                     ` Li Yu
2007-04-04 14:54                     ` Marcel Holtmann
2007-04-04 23:01                     ` Adam Kropelin
2007-04-04 23:12                       ` Jiri Kosina
2007-04-04 23:34                         ` Adam Kropelin
2007-04-05  8:36                           ` Jiri Kosina
2007-04-05 14:08                             ` Adam Kropelin
     [not found]                           ` <46189FE3.6050206@gmail.com>
2007-04-09  1:54                             ` [linux-usb-devel] HID bus prototype - 20070408 Li Yu
2007-04-10  9:40                             ` Jiri Kosina
2007-04-10 11:00                               ` [linux-usb-devel] " Li Yu
2007-04-05  1:25                     ` [linux-usb-devel] [RFC] HID bus design overview Li Yu
2007-04-05  3:09                       ` Dmitry Torokhov
2007-04-05  5:28                         ` Li Yu
2007-04-05  6:47                           ` Li Yu
2007-04-06  0:58                         ` Li Yu
2007-03-29  5:37         ` Li Yu
2007-03-29  9:24           ` Jiri Kosina
2007-04-02 12:19           ` Marcel Holtmann
  -- strict thread matches above, loose matches on Subject: below --
2007-04-02 11:57 Nicolas Mailhot
2007-04-03  1:40 ` Li Yu
2007-04-03  3:41   ` Dmitry Torokhov
2007-04-03  9:00   ` Jiri Kosina
2007-04-05 18:10     ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4610D771.4020806@codemercs.com \
    --to=marquardt@codemercs.com \
    --cc=dtor@insightbb.com \
    --cc=hongzhiyi@ccoss.com.cn \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=marcel@holtmann.org \
    --cc=raise.sail@gmail.com \
    --cc=yanghong@ccoss.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox