From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760125AbbKTM3E (ORCPT ); Fri, 20 Nov 2015 07:29:04 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:63696 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743AbbKTM3B (ORCPT ); Fri, 20 Nov 2015 07:29:01 -0500 From: Arnd Bergmann To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, Peter Zijlstra , Sascha Hauer , Liam Girdwood , linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH, once again] regulator: core: avoid unused variable warning Date: Fri, 20 Nov 2015 13:28:02 +0100 Message-ID: <4611580.31jynMWjmL@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151120122400.GA1929@sirena.org.uk> References: <4219157.sstthfjICN@wuerfel> <15541673.tdJ35xzzlG@wuerfel> <20151120122400.GA1929@sirena.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:UcI0pBvj0fCQ8MttWmHKsoVcmKmDITCpheuGFs5C1Zk4E88HPI5 5cuG1hBr0irXt5C7orzNQbZGhPFTPdU46ybQutlggcwPZWoJousIkl4VtBqkuE2GZ52XeDD eO8lHN5chSVp88+O46YAVokJM5mZah5MV0vkRx2VHYEPt+tTihoz+dfTBG2eqWGJiWnGiEu 4NvzK9u3c8Tklm+ONV/dA== X-UI-Out-Filterresults: notjunk:1;V01:K0:RZHreymrGck=:ERI9Yatj9uoeepKwlTUhsK A3CJYCM/8jfND4/hAU9yTmFTsd5RFfXjqCxqJFd/StoqS1hb7yclIlNS9NYb5yViOGctHdhq0 kTMa7uMj6j+1/6wyZaiWj8VEuJKWtseFPmDU7t+cL7yDxnha4o52LOrA2bd2aKFRlHiUXLezV SbPG/MsjkMzFt0CF+Plhi2BXrOSlJngcRa6138C32tTZq5hrh3a2vU9YQhKy9Xp2HGRyGbfYQ OLaEfvBXKBuuSU4xW8SDNLi83fra0X99uDzRSfkuoW/8eON7dkdOXRIcXY5dygSacbmw3rjPJ UmK32lMBG8dx+EuacGkrqiRfRq/jS7Ei/52RIssyzM0IF07LHLcnvxXqKolP/okvuG5QnHQNN YIVTySVQGo456w5fCGjOZfwf8LN5qi5NKroidAxo3OUSU/4wbO0391TL+pol6zGejOVoWfdkD ThHRJPjs/eSk0NbQwcYJ4wue/ouUX/Df7c9Ffwqo87l37FnNeFfOlJYis9579EwGQnNB4lQo3 yinSuUeBZXGQi64cjaNw8Kn55gEjaZozQ1NlCsHyMAMFiRrKLBKVNw9X3le8if9OWfOm8k3q6 ALx7ANTujnrdqXH+sXjTCIetL0coA9t7tyc4XNeS83rFYlT7c/UqQM/U01Lwe0OUESPbenKe0 /O1xeFObQ19BGseTfO4WIigGyza5sUNeLSTayt6cvrny+opid40X8G+WsHyqUHaEJ/pkrhl2v LKtE/CxTtIqSzyat Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 20 November 2015 12:24:00 Mark Brown wrote: > On Fri, Nov 20, 2015 at 01:12:00PM +0100, Arnd Bergmann wrote: > > On Friday 20 November 2015 11:41:27 Mark Brown wrote: > > > > Can we please at least have a comment explaining that this is working > > > around lockdep limitations? > > > Not sure which limitation you are referring to. Maybe you could just > > modify the changelog text as you like when applying the patch? > > > I tried to capture the fact that mutex_lock_nested() intentionally > > doesn't evaluate its second argument when CONFIG_DEBUG_LOCK_ALLOC > > is not set, but that appears to be less of a limitation than a > > choice of the interface. > > That's the limitation (or intereface choice or whatever) that I'm > talking about - the code looks like a function call so not evaulating > the second argument is surprising. I'm looking for something in the > code rather than the changelog so it doesn't get cleaned up later. > Got it. Will send a new version soon. Arnd