From: "Alexander E. Patrakov" <patrakov@ums.usu.ru>
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Jan Engelhardt <jengelh@linux01.gwdg.de>,
Paul LeoNerd Evans <leonerd@leonerd.org.uk>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] vt: Expose system-wide UTF-8 default setting via sysfs
Date: Tue, 03 Apr 2007 10:06:30 +0600 [thread overview]
Message-ID: <4611D2C6.3090102@ums.usu.ru> (raw)
In-Reply-To: <4611ACCD.5000305@gmail.com>
Antonino A. Daplas wrote:
> Create a variable, default_utf8, that defines the system-wide default UTF-8
> setting. This variable can be altered via sysfs. If the variable is properly
> set, this should mimimize breakage of UTF-8 encoded consoles when doing a
> reset or echo -e '\033c' and of newly opened/allocated consoles.
>
> This is based from patches by Jan Engelhardt and Paul LeoNerd Evans.
>
> Signed-off-by: Antonino Daplas <adaplas@gmail.com>
> ---
>> I think you're missing the whole point of console reset. Its purpose is
>> to force the console into a known-good state. The fewer pieces of state
>> it leaves unset, the better. To some degree it's less important what
>> that state actually is.
>
> Okay, you convinced me. Hopefully this is acceptable to all parties.
>
> Andrew,
>
> If everybody agrees, can you drop the previous patch I sent to you, and use
> this instead?
>
> Tony
> +static int default_utf8;
> +module_param(default_utf8, int, S_IRUGO | S_IWUSR);
Module parameter without description and documentation? Yes, I understand
that it is impossible to make vt a module. How about adding a line to
Documentation/kernel-parameters.txt?
Other than that, the patch looks like a useful change.
--
Alexander E. Patrakov
next prev parent reply other threads:[~2007-04-03 4:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-03 1:24 [PATCH] vt: Expose system-wide UTF-8 default setting via sysfs Antonino A. Daplas
2007-04-03 4:06 ` Alexander E. Patrakov [this message]
2007-04-03 5:47 ` Antonino A. Daplas
2007-04-03 16:20 ` Pavel Machek
2007-04-03 16:35 ` Paul LeoNerd Evans
2007-04-04 5:39 ` Antonino A. Daplas
2007-04-04 8:01 ` Pavel Machek
2007-04-06 14:30 ` Paul LeoNerd Evans
2007-04-06 15:39 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4611D2C6.3090102@ums.usu.ru \
--to=patrakov@ums.usu.ru \
--cc=adaplas@gmail.com \
--cc=akpm@osdl.org \
--cc=hpa@zytor.com \
--cc=jengelh@linux01.gwdg.de \
--cc=leonerd@leonerd.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox