From: Randy Dunlap <randy.dunlap@oracle.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>,
sam@ravnborg.org, davem@davemloft.net
Subject: Re: [PATCH] make csum_partial obj-y
Date: Tue, 03 Apr 2007 12:09:33 -0700 [thread overview]
Message-ID: <4612A66D.5090009@oracle.com> (raw)
In-Reply-To: <p731wj1z0or.fsf@bingen.suse.de>
Andi Kleen wrote:
> Randy Dunlap <randy.dunlap@oracle.com> writes:
>
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Fixes kernel bugzilla #8242:
>>
>> Move csum_partial() from lib-y to obj-$(CONFIG_CSUM_PARTIAL)
>> so that modules can use it.
>>
>> CONFIG_BLK_DEV_MD (md/raid driver) needs csum_partial(),
>> even when CONFIG_NET=n and BLK_DEV_MD=m, so build it as an
>> object to force it being built and available.
>>
>> REISERFS with XATTR=y also needs csum_partial(), so that
>> is enforced here.
>
> They are all broken because csum_partial gives different values
> on different architectures. You're just extending that to
> possibly more subsystems.
So the ones that can be localized (BLK_DEV_MD and REISERFS)
should have their own versions?
How does the networking code work across multiple architectures?
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-04-03 19:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-03 18:26 [PATCH] make csum_partial obj-y Randy Dunlap
2007-04-03 20:02 ` Andi Kleen
2007-04-03 19:09 ` Randy Dunlap [this message]
2007-04-03 19:23 ` Andi Kleen
2007-04-03 19:27 ` David Miller
2007-04-03 19:31 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4612A66D.5090009@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox