From: Ethan Solomita <solo@google.com>
To: maneesh@in.ibm.com
Cc: Dipankar Sarma <dipankar@in.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg KH <greg@kroah.com>, Martin Bligh <mbligh@google.com>,
Rohit Seth <rohitseth@google.com>,
viro@ftp.linux.org.uk, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix sysfs_readdir oops (was Re: sysfs reclaim crash)
Date: Tue, 03 Apr 2007 13:46:10 -0700 [thread overview]
Message-ID: <4612BD12.4000905@google.com> (raw)
In-Reply-To: <20070403073830.GA9796@in.ibm.com>
Maneesh Soni wrote:
> I have modified the previous patch (which was dropped from -mm) and now keeping
> the statement making s_dentry as NULL in sysfs_d_iput(), so this should
> _safely_ fix sysfs_readdir() oops.
>
If you could find some additional places in sysfs code to add new
BUG() checks I'd appreciate it. Especially if it turns out that you
can't reproduce it, I'd like to have as many asserts as is reasonable.
-- Ethan
next prev parent reply other threads:[~2007-04-03 20:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070319140238.cbf28b2b.akpm@linux-foundation.org>
[not found] ` <20070321134654.5wkqpfbpk0ggwks8@imap.linux.ibm.com>
[not found] ` <20070321182123.GA12602@in.ibm.com>
[not found] ` <20070323043047.GA5641@in.ibm.com>
[not found] ` <20070322210504.3b052139.akpm@linux-foundation.org>
[not found] ` <46042DDF.5060000@google.com>
2007-03-24 3:05 ` sysfs reclaim crash Maneesh Soni
2007-03-27 18:27 ` Ethan Solomita
2007-03-27 18:49 ` Maneesh Soni
2007-04-03 7:38 ` [PATCH] fix sysfs_readdir oops (was Re: sysfs reclaim crash) Maneesh Soni
2007-04-03 20:46 ` Ethan Solomita [this message]
2007-04-07 8:31 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4612BD12.4000905@google.com \
--to=solo@google.com \
--cc=akpm@linux-foundation.org \
--cc=dipankar@in.ibm.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=mbligh@google.com \
--cc=rohitseth@google.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox