From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 0A503E95A67
	for <linux-kernel@archiver.kernel.org>; Sun,  8 Oct 2023 13:00:16 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1344771AbjJHNAO convert rfc822-to-8bit (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Sun, 8 Oct 2023 09:00:14 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57998 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1344746AbjJHNAN (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 8 Oct 2023 09:00:13 -0400
Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB888B6;
        Sun,  8 Oct 2023 06:00:10 -0700 (PDT)
Received: from i53875a3c.versanet.de ([83.135.90.60] helo=diego.localnet)
        by gloria.sntech.de with esmtpsa  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
        (Exim 4.94.2)
        (envelope-from <heiko@sntech.de>)
        id 1qpTO2-0004O7-Qw; Sun, 08 Oct 2023 14:59:58 +0200
From:   Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To:     Rob Herring <robh+dt@kernel.org>, Sam Edwards <cfsworks@gmail.com>
Cc:     linux-rockchip@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org,
        Daniel =?utf-8?B?S3VraWXFgmE=?= <daniel@kukiela.pl>,
        Sven Rademakers <sven.rademakers@gmail.com>,
        Lokesh Poovaragan <loki@gimmeapis.com>,
        Sam Edwards <CFSworks@gmail.com>
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add Turing RK1 SoM support
Date:   Sun, 08 Oct 2023 14:59:57 +0200
Message-ID: <4613093.CvnuH1ECHv@diego>
In-Reply-To: <20231007043600.151908-4-CFSworks@gmail.com>
References: <20231007043600.151908-1-CFSworks@gmail.com>
 <20231007043600.151908-4-CFSworks@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sam,

Am Samstag, 7. Oktober 2023, 06:36:00 CEST schrieb Sam Edwards:
> The Turing RK1 is an upcoming RK3588-based SoM from Turing Machines,
> designed on the Jetson SO-DIMM form factor and meant to be compatible
> with most Jetson carrier boards (but especially the Turing Pi 2 cluster
> board from the same vendor). It has the typical I/O you'd expect from
> a Jetson board, including:
> 
> - Two UARTs (UART9 for console, UART2 is auxiliary)
> - PCI Express (2.0 x1 + 3.0 x4)
> - Gigabit Ethernet
> - On-board eMMC
> - PWM fan w/ tach
> - USB-OTG [1]
> - HDMI and MIPI DSI [1]
> - Miscellaneous external GPIO, I²C, SPI lines [1]
> 
> Beyond that, it is pretty similar to the RK3588 EVB (in terms of PMICs,
> RTC, etc).
> 
> This patch introduces a devicetree to enable most[1] of the SoM I/O.
> 
> [1] These peripherals are not addressed with this patch.
> 
> Signed-off-by: Sam Edwards <CFSworks@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../boot/dts/rockchip/rk3588-turing-rk1.dts   | 627 ++++++++++++++++++

This is more a general concern. You're introducing the rk1 as a dts file
but the from looking at the module-page and your patch description
this is "just" a SOM that most likely cannot run without some sort of carrier
board.

In the rockchip devicetree directory you can see a number of som boards
as som-dtsi + base-board forming a full product. Simply because the number
of usable peripherals will highly depend on what baseboard is used.

Thanks
Heiko