From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1766910AbXDDTyq (ORCPT ); Wed, 4 Apr 2007 15:54:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1766911AbXDDTyq (ORCPT ); Wed, 4 Apr 2007 15:54:46 -0400 Received: from mga02.intel.com ([134.134.136.20]:3861 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1766910AbXDDTyp (ORCPT ); Wed, 4 Apr 2007 15:54:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: i="4.14,372,1170662400"; d="scan'208"; a="221960947:sNHT20210505" Message-ID: <46140276.1050905@intel.com> Date: Wed, 04 Apr 2007 12:54:30 -0700 From: "Kok, Auke" User-Agent: Mail/News 1.5.0.10 (X11/20070311) MIME-Version: 1.0 To: "Jeff V. Merkey" CC: Linux kernel Subject: Re: Latest e1000 7.3.20 driver busted with 2.6.20.4 References: <4613E230.6080608@wolfmountaingroup.com> <4613FD2C.101@intel.com> <461400A1.7080907@wolfmountaingroup.com> In-Reply-To: <461400A1.7080907@wolfmountaingroup.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jeff V. Merkey wrote: > Kok, Auke wrote: > >> Jeff V. Merkey wrote: >> >>> CC [M] drivers/net/chelsio/mv88x201x.o >>> CC [M] drivers/net/chelsio/my3126.o >>> LD [M] drivers/net/chelsio/cxgb.o >>> CC drivers/net/e1000/e1000_main.o >>> drivers/net/e1000/e1000_main.c:1185:45: error: macro "INIT_WORK" >>> passed 3 arguments, but takes just 2 >>> ared (first use in this function) >>> drivers/net/e1000/e1000_main.c:1184: error: (Each undeclared >>> identifier is reported only once >>> drivers/net/e1000/e1000_main.c:1184: error: for each function it >>> appears in.) >>> make[3]: *** [drivers/net/e1000/e1000_main.o] Error 1 >>> make[2]: *** [drivers/net/e1000] Error 2 >>> make[1]: *** [drivers/net] Error 2 >>> make: *** [drivers] Error 2 >> >> this is hardly a thread for lkml as you're posting about out >> out-of-tree driver. This issue has also been fixed in 7.4.35 which >> was released last week on e1000.sf.net. In the future, please post >> this stuff to e1000-devel@lists.sourceforge.net where we discuss the >> out-of-tree driver. >> >> Cheers, >> >> Auke >> > Thanks. I'll download Intel's latest driver and test it. I wasn't > discussing the out of tree driver (why do you have a broken Linux out of > tree driver, BTW? If its for Linux, shouldn't it be updated here > first) but the driver in 2.6.20.4 (which is missing support four > additional chipsets). Our hardware release schedule is not aligned with kernel releases, and customers need to have a working (and tested) driver once the hardware is released. We try to get the updates into the kernel as fast as we can, but often meet resistance, as the two parties involved just have different interests. Are you saying that the in-kernel driver in 2.6.20.4 is broken? That is bizarre, and should never happen. It compiles fine for me here... Auke