Re: [PATCH 2.6.21-rc5] kernel/time.c: add missing symbol exports

john stultz
2007-04-04T21:38:45Z

On Wed, 2007-04-04 at 14:30 -0700, Andrew Morton wrote:
> On Wed, 04 Apr 2007 23:13:11 +0200
> Thomas Bittermann <t.bittermann@online.de> wrote:
>
> > Andrew Morton schrieb:
> > > On Wed, 04 Apr 2007 22:20:54 +0200
> > > Thomas Bittermann <t.bittermann@online.de> wrote:
> > >
> > >> This patch adds 2 missing symbol exports:
> > >>
> > >> jiffies_to_timeval
> > >> timeval_to_jiffies
> > >
> > > I don't see any in-tree code which needs these symbols?
> > >
> > > The exports might make sense from a consistency POV, but I'd be interested
> > > in knowing what motivated this change?
> > I'm working on a Fedora 7 LiveCD which integrates dm-raid4-5
> > (http://people.redhat.com/~heinzm/sw/dm/dm-raid45/readme). dm-raid4-5.c uses
> > jiffies_to_timeval() ...
> >
>
> Fair enough.
>
> John/Ingo/Thomas: have you any problems with exporting the above to modules
> (with EXPORT_SYMBOL)?

As long as jiffies and HZ is exported, I don't see why not.

thanks
-john