From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161222AbXDEF7H (ORCPT ); Thu, 5 Apr 2007 01:59:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161223AbXDEF7H (ORCPT ); Thu, 5 Apr 2007 01:59:07 -0400 Received: from terminus.zytor.com ([192.83.249.54]:41636 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161222AbXDEF7G (ORCPT ); Thu, 5 Apr 2007 01:59:06 -0400 Message-ID: <46149000.40200@zytor.com> Date: Wed, 04 Apr 2007 22:58:24 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Rusty Russell CC: Steven Rostedt , virtualization@lists.osdl.org, Linux Kernel Mailing List , Kyle Moffett Subject: Re: [PATCH] Lguest32 print hex on bad reads and writes References: <1175714071.9371.31.camel@localhost.localdomain> <1175742090.12230.630.camel@localhost.localdomain> <72C854B9-1A7F-44C5-9D62-B6B63F3A6DE7@mac.com> <1175742848.9371.33.camel@localhost.localdomain> <1175744057.12230.632.camel@localhost.localdomain> In-Reply-To: <1175744057.12230.632.camel@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Rusty Russell wrote: > On Wed, 2007-04-04 at 23:14 -0400, Steven Rostedt wrote: >> On Wed, 2007-04-04 at 23:06 -0400, Kyle Moffett wrote: >> >>>> (Erk, I wonder what I was thinking when I wrote that?) Can I ask >>>> for %#x (or 0x%x)? I'm easily confused. >>> How about "%p" for pointers? >> But that would require casting the numbers to pointers. > > And the kernel's printk doesn't put 0x on pointers anyway, last I > checked 8( > That's really the bug. Let's fix it. -hpa