From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753135AbXDEQPd (ORCPT ); Thu, 5 Apr 2007 12:15:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753124AbXDEQPc (ORCPT ); Thu, 5 Apr 2007 12:15:32 -0400 Received: from mx1.redhat.com ([66.187.233.31]:57206 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753134AbXDEQPb (ORCPT ); Thu, 5 Apr 2007 12:15:31 -0400 Message-ID: <46152099.7060005@redhat.com> Date: Thu, 05 Apr 2007 12:15:21 -0400 From: Rik van Riel Organization: Red Hat, Inc User-Agent: Thunderbird 1.5.0.7 (X11/20061008) MIME-Version: 1.0 To: Jakub Jelinek CC: Ulrich Drepper , Andrew Morton , Andi Kleen , Linux Kernel , linux-mm@kvack.org, Hugh Dickins Subject: Re: missing madvise functionality References: <46128051.9000609@redhat.com> <46128CC2.9090809@redhat.com> <20070403172841.GB23689@one.firstfloor.org> <20070403125903.3e8577f4.akpm@linux-foundation.org> <4612B645.7030902@redhat.com> <20070403202937.GE355@devserv.devel.redhat.com> <4614A5CC.5080508@redhat.com> <20070405094504.GM355@devserv.devel.redhat.com> In-Reply-To: <20070405094504.GM355@devserv.devel.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jakub Jelinek wrote: > + /* FIXME: POSIX says that MADV_DONTNEED cannot throw away data. */ > case MADV_DONTNEED: > + case MADV_FREE: > error = madvise_dontneed(vma, prev, start, end); > break; > > I think you should only use the new behavior for madvise MADV_FREE, not for > MADV_DONTNEED. I will. However, we need to double-use MADV_DONTNEED in this patch for now, so Ulrich's test glibc can be used easily :) -- Politics is the struggle between those who want to make their country the best in the world, and those who believe it already is. Each group calls the other unpatriotic.