From: "H. Peter Anvin" <hpa@zytor.com>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Andi Kleen <ak@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: limit mwait_idle to Intel CPUs
Date: Thu, 05 Apr 2007 09:55:32 -0700 [thread overview]
Message-ID: <46152A04.1010009@zytor.com> (raw)
In-Reply-To: <20070405162049.GB14326@alberich.amd.com>
Andreas Herrmann wrote:
>
> It is not equivalent. Usually users check /proc/cpuinfo for their
> CPU features. Deleting that flag is kind of obfuscation.
>
> I guess some time ago people did not care about their "svm" or "vmx"
> flags. Nowadays (e.g. with kvm) some people are quite happy
> if one of those strings occurs in /proc/cpuinfo (and they are quite
> disappointed if this feature was disabled by BIOS).
>
What you're saying is that you want it to appear in /proc/cpuinfo for
marketing reasons even though it's not usable.
The ones in /proc/cpuinfo are cooked values anyway; there is plenty of
history to that effect.
I would agree with Andi that if as far as Linux is concerned mwait is
unusable on AMD Fam10 processors, then the CPU detection code should
turn this bit off on AMD Fam10 processors.
-hpa
next prev parent reply other threads:[~2007-04-05 16:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 14:00 [PATCH] x86: limit mwait_idle to Intel CPUs Andreas Herrmann
2007-04-05 14:24 ` Andi Kleen
2007-04-05 14:44 ` Andreas Herrmann
2007-04-05 15:37 ` Andi Kleen
2007-04-05 16:20 ` Andreas Herrmann
2007-04-05 16:55 ` H. Peter Anvin [this message]
2007-04-05 17:06 ` Markus Rechberger
2007-04-05 17:36 ` H. Peter Anvin
2007-04-05 21:12 ` aherrman
2007-04-05 21:19 ` H. Peter Anvin
2007-04-05 17:05 ` Andi Kleen
2007-04-05 14:46 ` Langsdorf, Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46152A04.1010009@zytor.com \
--to=hpa@zytor.com \
--cc=ak@suse.de \
--cc=andreas.herrmann3@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox