From: Martin Bligh <mbligh@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] leave loglevel at 7 through sysrq output so you can actually read it
Date: Thu, 05 Apr 2007 15:53:06 -0700 [thread overview]
Message-ID: <46157DD2.4050502@google.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 282 bytes --]
We carefully set loglevel to 7, and print the sysrq messsage
as to what event we're doing, but we can't actually see
the output as it sets it back before calling the handler,
rather than after.
Move the assignment down one line.
Signed-off-by: Martin J. Bligh <mbligh@google.com>
[-- Attachment #2: linux-2.6.21-rc5-git10-loglevel --]
[-- Type: text/plain, Size: 655 bytes --]
diff -aurpN -X /home/mbligh/.diff.exclude linux-2.6.21-rc5-git10/drivers/char/sysrq.c linux-2.6.21-rc5-git10-loglevel/drivers/char/sysrq.c
--- linux-2.6.21-rc5-git10/drivers/char/sysrq.c 2007-04-03 11:23:54.000000000 -0700
+++ linux-2.6.21-rc5-git10-loglevel/drivers/char/sysrq.c 2007-04-05 15:49:40.000000000 -0700
@@ -421,8 +421,8 @@ void __handle_sysrq(int key, struct tty_
*/
if (!check_mask || sysrq_on_mask(op_p->enable_mask)) {
printk("%s\n", op_p->action_msg);
- console_loglevel = orig_log_level;
op_p->handler(key, tty);
+ console_loglevel = orig_log_level;
} else {
printk("This sysrq operation is disabled.\n");
}
next reply other threads:[~2007-04-05 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 22:53 Martin Bligh [this message]
2007-04-06 16:31 ` [PATCH] leave loglevel at 7 through sysrq output so you can actually read it Roman Zippel
2007-04-06 16:33 ` Martin Bligh
2007-04-06 17:06 ` Roman Zippel
2007-04-06 17:35 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46157DD2.4050502@google.com \
--to=mbligh@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox