Re: [PATCH] Bugfix for VMI paravirt ops

Zachary Amsden
2007-04-06T00:22:27Z

Jeremy Fitzhardinge wrote:
> Zachary Amsden wrote:
>
>> No, they are totally dependent. The reason interrupts are disabled is
>> to stop kmap_atomic in interrupt handlers. With the kmap_atomic_pte
>> changes, the whole interrupt disable jibberish goes away.
>>
>
> But kmap_atomic_pte is a special case of kmap_atomic for ptes.
> Interrupt routines can still use plain kmap_atomic for bouncebuffers and
> so on.
>

Ah, yes.

> A more general patch would be to make kmap/unmap_atomic pv_ops, and then
> they can all be rolled together. I.e: check the type to see if special
> pte handling needs to happen, etc.
>

So the clean fix for this is still even further out. I don't think I
want to hook kmap/unmap as paravirt-ops.

Zach