From: Zachary Amsden <zach@vmware.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andi Kleen <ak@suse.de>, Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] Bugfix for VMI paravirt ops
Date: Thu, 05 Apr 2007 17:20:30 -0700 [thread overview]
Message-ID: <4615924E.8020009@vmware.com> (raw)
In-Reply-To: <461590EA.10605@goop.org>
Jeremy Fitzhardinge wrote:
> Zachary Amsden wrote:
>
>> No, they are totally dependent. The reason interrupts are disabled is
>> to stop kmap_atomic in interrupt handlers. With the kmap_atomic_pte
>> changes, the whole interrupt disable jibberish goes away.
>>
>
> But kmap_atomic_pte is a special case of kmap_atomic for ptes.
> Interrupt routines can still use plain kmap_atomic for bouncebuffers and
> so on.
>
Ah, yes.
> A more general patch would be to make kmap/unmap_atomic pv_ops, and then
> they can all be rolled together. I.e: check the type to see if special
> pte handling needs to happen, etc.
>
So the clean fix for this is still even further out. I don't think I
want to hook kmap/unmap as paravirt-ops.
Zach
next prev parent reply other threads:[~2007-04-06 0:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 23:29 [PATCH] Bugfix for VMI paravirt ops Zachary Amsden
2007-04-05 23:34 ` Zachary Amsden
2007-04-05 23:55 ` Andrew Morton
2007-04-05 23:54 ` Andi Kleen
2007-04-06 0:01 ` Zachary Amsden
2007-04-06 0:08 ` Jeremy Fitzhardinge
2007-04-06 0:09 ` Zachary Amsden
2007-04-06 0:14 ` Jeremy Fitzhardinge
2007-04-06 0:20 ` Zachary Amsden [this message]
2007-04-06 0:33 ` Jeremy Fitzhardinge
2007-04-06 0:45 ` Zachary Amsden
2007-04-06 0:52 ` Jeremy Fitzhardinge
2007-04-06 0:54 ` Zachary Amsden
2007-04-06 1:31 ` Jeremy Fitzhardinge
2007-04-06 1:32 ` Zachary Amsden
2007-04-06 1:36 ` Jeremy Fitzhardinge
2007-04-06 1:42 ` Zachary Amsden
2007-04-06 1:19 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4615924E.8020009@vmware.com \
--to=zach@vmware.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox