From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1767486AbXDFBoO (ORCPT ); Thu, 5 Apr 2007 21:44:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1767492AbXDFBoO (ORCPT ); Thu, 5 Apr 2007 21:44:14 -0400 Received: from smtp-outbound-1.vmware.com ([65.113.40.141]:38019 "EHLO smtp-outbound-1.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1767486AbXDFBoN (ORCPT ); Thu, 5 Apr 2007 21:44:13 -0400 Message-ID: <4615A579.10103@vmware.com> Date: Thu, 05 Apr 2007 18:42:17 -0700 From: Zachary Amsden User-Agent: Thunderbird 1.5.0.10 (X11/20070221) MIME-Version: 1.0 To: Jeremy Fitzhardinge CC: Andi Kleen , Andrew Morton , Linux Kernel Mailing List , Linus Torvalds Subject: Re: [PATCH] Bugfix for VMI paravirt ops References: <46158674.5090709@vmware.com> <200704060154.41574.ak@suse.de> <46158DE1.4050508@vmware.com> <46158F8E.1050807@goop.org> <46158FBE.3090105@vmware.com> <461590EA.10605@goop.org> <4615924E.8020009@vmware.com> <46159555.4020706@goop.org> <4615982A.1070700@vmware.com> <461599C1.50002@goop.org> <46159A2A.8050804@vmware.com> <4615A2F8.7040602@goop.org> <4615A32D.2080209@vmware.com> <4615A431.5040104@goop.org> In-Reply-To: <4615A431.5040104@goop.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jeremy Fitzhardinge wrote: > Zachary Amsden wrote: > >> Do you mean kmap_atomic_pfn? >> > > Yes. > > >> kunmap_atomic can stay lazy (at least for VMI), actually, but it >> doesn't help since it happens outside the spin lock. >> > > May as well be consistent. Or do you mean you can't flush outside the > spinlock, even if there's nothing pending? > Consistency is good. Flush is always fine, just an extra function call. Zach