[PATCH] leave loglevel at 7 through sysrq output so you can actually read it

[PATCH] leave loglevel at 7 through sysrq output so you can actually read it

[Martin Bligh]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

We carefully set loglevel to 7, and print the sysrq messsage
as to what event we're doing, but we can't actually see
the output as it sets it back before calling the handler,
rather than after.

Move the assignment down one line.

Signed-off-by: Martin J. Bligh <mbligh@google.com>

[-- Attachment #2: linux-2.6.21-rc5-git10-loglevel --]
[-- Type: text/plain, Size: 655 bytes --]

diff -aurpN -X /home/mbligh/.diff.exclude linux-2.6.21-rc5-git10/drivers/char/sysrq.c linux-2.6.21-rc5-git10-loglevel/drivers/char/sysrq.c
--- linux-2.6.21-rc5-git10/drivers/char/sysrq.c	2007-04-03 11:23:54.000000000 -0700
+++ linux-2.6.21-rc5-git10-loglevel/drivers/char/sysrq.c	2007-04-05 15:49:40.000000000 -0700
@@ -421,8 +421,8 @@ void __handle_sysrq(int key, struct tty_
 		 */
 		if (!check_mask || sysrq_on_mask(op_p->enable_mask)) {
 			printk("%s\n", op_p->action_msg);
-			console_loglevel = orig_log_level;
 			op_p->handler(key, tty);
+			console_loglevel = orig_log_level;
 		} else {
 			printk("This sysrq operation is disabled.\n");
 		}

Re: [PATCH] leave loglevel at 7 through sysrq output so you can actually read it

[Roman Zippel]

On Thu, 5 Apr 2007, Martin Bligh wrote:

> We carefully set loglevel to 7, and print the sysrq messsage
> as to what event we're doing, but we can't actually see
> the output as it sets it back before calling the handler,
> rather than after.
> 
> Move the assignment down one line.

I think you have to tell sysrq_handle_loglevel() about this too...

bye, Roman

Re: [PATCH] leave loglevel at 7 through sysrq output so you can actually read it

[Martin Bligh]

Roman Zippel wrote:
> 
> On Thu, 5 Apr 2007, Martin Bligh wrote:
> 
>> We carefully set loglevel to 7, and print the sysrq messsage
>> as to what event we're doing, but we can't actually see
>> the output as it sets it back before calling the handler,
>> rather than after.
>>
>> Move the assignment down one line.
> 
> I think you have to tell sysrq_handle_loglevel() about this too...

Not sure why? That just changes the current loglevel, and seems
unaffected.

I did test the patch, and it works fine.

M.

Re: [PATCH] leave loglevel at 7 through sysrq output so you can actually read it

[Roman Zippel]

Hi,

On Fri, 6 Apr 2007, Martin Bligh wrote:

> > I think you have to tell sysrq_handle_loglevel() about this too...
> 
> Not sure why? That just changes the current loglevel, and seems
> unaffected.

Who's the last to set console_loglevel?

> I did test the patch, and it works fine.

Did you check /proc/sys/kernel/printk?

bye, Roman

Re: [PATCH] leave loglevel at 7 through sysrq output so you can actually read it

[Roman Zippel]

Hi,

On Fri, 6 Apr 2007, Roman Zippel wrote:

> > I did test the patch, and it works fine.
> 
> Did you check /proc/sys/kernel/printk?

BTW for even more fun check this with "echo 4 > /proc/sys/kernel/sysrq".

bye, Roman