From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933026AbXDFVHW (ORCPT ); Fri, 6 Apr 2007 17:07:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932987AbXDFVHW (ORCPT ); Fri, 6 Apr 2007 17:07:22 -0400 Received: from terminus.zytor.com ([192.83.249.54]:45008 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933026AbXDFVHV (ORCPT ); Fri, 6 Apr 2007 17:07:21 -0400 Message-ID: <4616B678.1050202@zytor.com> Date: Fri, 06 Apr 2007 14:07:04 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Jeremy Fitzhardinge CC: "Eric W. Biederman" , Linus Torvalds , Oleg Nesterov , Robin Holt , Chris Snook , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: init's children list is long and slows reaping children. References: <20070406084250.GA179@tv-sign.ru> <20070406094413.GA673@tv-sign.ru> <20070406154750.GA541@tv-sign.ru> <46169A34.3030808@zytor.com> <4616B5E7.9070508@goop.org> In-Reply-To: <4616B5E7.9070508@goop.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jeremy Fitzhardinge wrote: > Eric W. Biederman wrote: >> I'm guessing the issue is nash just calls wait and doesn't check the >> returned pid value, assuming it is the only child it forked returning. >> Which is valid except when you are running as pid == 1. >> > > Hm, that's always a bug; a process can always have children it doesn't > expect (think forking, and then the parent execs). > Not if the process already forked. But yes, in general this is a major screwup. -hpa