From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] Char: cyclades, remove volatiles
Date: Sat, 07 Apr 2007 09:28:37 +0200 [thread overview]
Message-ID: <46174825.4050509@gmail.com> (raw)
In-Reply-To: <20070406171406.317ea28a.akpm@linux-foundation.org>
Andrew Morton napsal(a):
> On Wed, 4 Apr 2007 23:45:38 +0200 (CEST) Jiri Slaby <jirislaby@gmail.com> wrote:
>
>> cyclades, remove volatiles
>
> The other changes seem uncontroversial, but this one has the potential
> to change runtime behaviour. And cyclades.c is a driver which some people
> actually use ;)
Well, don't you know anybody with Z card, please?
But all volatiles were
- used locally (loop variables, nonptr count read once from HW), so that nothing
has a chance to change them in the memory.
- accessed by readX/writeX (pointers to mapped HW) and that should be OK
> Have these changes been runtime-tested?
Yes this time :), I have at least PCI Y cyclades card within reach to test.
thanks,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
next prev parent reply other threads:[~2007-04-07 7:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 21:44 [PATCH 1/5] Char: cyclades, remove PAUSE Jiri Slaby
2007-04-04 21:45 ` [PATCH 2/5] Char: cyclades, cy_readX/writeX cleanup Jiri Slaby
2007-04-04 21:45 ` [PATCH 3/5] Char: cyclades, timer cleanup Jiri Slaby
2007-04-04 21:45 ` [PATCH 4/5] Char: cyclades, remove volatiles Jiri Slaby
2007-04-07 0:14 ` Andrew Morton
2007-04-07 7:28 ` Jiri Slaby [this message]
2007-04-09 14:20 ` John Stoffel
2007-04-10 11:43 ` Jiri Slaby
2007-04-10 15:03 ` John Stoffel
2007-04-04 21:45 ` [PATCH 5/5] Char: cyclades, remove useless casts Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46174825.4050509@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox