From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753098AbXDIMCg (ORCPT ); Mon, 9 Apr 2007 08:02:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753119AbXDIMCg (ORCPT ); Mon, 9 Apr 2007 08:02:36 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:53773 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753098AbXDIMCg (ORCPT ); Mon, 9 Apr 2007 08:02:36 -0400 Message-ID: <461A2B59.3090406@garzik.org> Date: Mon, 09 Apr 2007 08:02:33 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Jeff Garzik , Alan Cox , linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [RFC] pata_icside driver References: <20070330110022.GA21653@flint.arm.linux.org.uk> <20070330110800.GB21653@flint.arm.linux.org.uk> <20070408101826.GA5431@flint.arm.linux.org.uk> <20070408195956.4e7d50c0@the-village.bc.nu> <461990CE.8080609@pobox.com> <20070409105638.6b131b72@the-village.bc.nu> <461A1BEA.7000002@pobox.com> <461A1FC1.50809@garzik.org> <20070409113627.GB26874@flint.arm.linux.org.uk> In-Reply-To: <20070409113627.GB26874@flint.arm.linux.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.8 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Russell King wrote: > On Mon, Apr 09, 2007 at 07:13:05AM -0400, Jeff Garzik wrote: >> It should be noted, mainly for russell's benefit, that the ->irq_ack() >> hook is only called if a debug define is manually enabled in libata.h, >> in a single callsite. >> >> The number of people that actually use the hook -- kernel hackers >> debugging screaming interrupts -- can probably be counted on one hand. > > Ok, in that case it makes sense for me to set this to ata_dummy_irq_ack > since I don't have any additional status registers specific to the > interface. > > Presumably a similar change to pata_platform.c would be appropriate? I was just pointing out the practical reality. The proper implementation of the hook is likely /not/ a dummy on your platform. I presume you clear the interrupt condition by reading the ATA shadow register 'Status', like most other SFF-like controllers, so your implementation of ->irq_ack() should reflect that. The proper implementation is basically what Alan described: ata_irq_ack() minus the BMDMA bitbanging. Jeff