Re: [PATCH] NET: [UPDATED] Multiqueue network device support implementation.

Patrick McHardy
2007-04-11T05:48:19Z

Waskiewicz Jr, Peter P wrote:
>>This leaks the device. You treat every single-queue device as
>>having a single subqueue. If it doesn't get too ugly it would
>>be nice to avoid this and only allocate the subqueue states
>>for real multiqueue devices.
>
>
> We went back and forth on this. The reason we allocate a queue in every
> case, even on single-queue devices, was to make the stack not have
> branching for multiqueue and non-multiqueue devices. If we don't have
> at least one queue on a device, then we can't have
> netif_subqueue_stopped() in the hotpath unless we check if a device is
> multiqueue before. The original patches I released had this branching,
> and I was asked to not do that.

OK, thanks for the explanation.

>>>+ skb->queue_mapping =
>>>+ q->prio2band[q->band2queue[band&TC_PRIO_MAX]];
>>
>>
>>Does this needs to be cleared at some point again? TC actions
>>might redirect or mirror packets to other (multiqueue) devices.
>
>
> If an skb is redirected to another device, the skb should be filtered
> through that device's qdisc, yes?

Yes, but the device might not have a queue or use something different
than prio, so the value would stay the same. I think you need to clear
it before enqueueing a packet or alternatively when redirecting in the
mirred action.