From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Robert P. J. Day" <rpjday@mindspring.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add spaces on either side of case "..." operator.
Date: Tue, 10 Apr 2007 10:47:21 -0700 [thread overview]
Message-ID: <461BCDA9.2060206@goop.org> (raw)
In-Reply-To: <20070410090555.d847d466.akpm@linux-foundation.org>
Andrew Morton wrote:
> #define AUDIT_FIRST_USER_MSG 1100 /* Userspace messages mostly uninteresting to kernel */
> #define AUDIT_USER_AVC 1107 /* We filter this differently */
> #define AUDIT_LAST_USER_MSG 1199
>
> and CPP turns that into
>
> case 1100 ...1199:
> case 2100 ...2999:
>
> and it does the same when the comments are stripped from the #defines.
>
> So we were saved by the trailing space which cpp added to the expanded
> macro. I wonder why cpp did that, and to what extent one can rely cpp
> doing that.
I think its required to. If it didn't, it would be effectively pasting
two tokens together without the ## operator. But putting spaces in is
safer - or putting () around the numbers.
J
next prev parent reply other threads:[~2007-04-10 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 11:23 [PATCH] Add spaces on either side of case "..." operator Robert P. J. Day
2007-04-10 14:33 ` WANG Cong
2007-04-10 16:05 ` Andrew Morton
2007-04-10 17:47 ` Jeremy Fitzhardinge [this message]
2007-04-10 20:45 ` Alexey Dobriyan
2007-04-10 20:37 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461BCDA9.2060206@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox