* [PATCH] ahci.c: remove non-existing SB600 raid id
@ 2007-04-11 9:54 Conke Hu
2007-04-11 10:00 ` Tejun Heo
0 siblings, 1 reply; 4+ messages in thread
From: Conke Hu @ 2007-04-11 9:54 UTC (permalink / raw)
To: Jeff Garzik, Alan; +Cc: Tejun Heo, Linux Kernel Mailing List, linux-ide
SB600 RAID and SB600 SATA is the same controller and share the
same PCI ID 0x4380. There is such PCI ID 0x4381.
Signed-off-by: Conke Hu <conke.hu@gmail.com>
---------
diff -Nur linux-2.6.21-rc6-git3.orig/drivers/ata/ahci.c
linux-2.6.21-rc6-git3/drivers/ata/ahci.c
--- linux-2.6.21-rc6-git3.orig/drivers/ata/ahci.c 2007-04-22
18:38:39.000000000 +0800
+++ linux-2.6.21-rc6-git3/drivers/ata/ahci.c 2007-04-22 18:39:12.000000000 +0800
@@ -413,8 +413,7 @@
PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff, board_ahci_ign_iferr },
/* ATI */
- { PCI_VDEVICE(ATI, 0x4380), board_ahci_sb600 }, /* ATI SB600 non-raid */
- { PCI_VDEVICE(ATI, 0x4381), board_ahci }, /* ATI SB600 raid */
+ { PCI_VDEVICE(ATI, 0x4380), board_ahci_sb600 }, /* ATI SB600 */
/* VIA */
{ PCI_VDEVICE(VIA, 0x3349), board_ahci_vt8251 }, /* VIA VT8251 */
diff -Nur linux-2.6.21-rc6-git3.orig/include/linux/pci_ids.h
linux-2.6.21-rc6-git3/include/linux/pci_ids.h
--- linux-2.6.21-rc6-git3.orig/include/linux/pci_ids.h 2007-04-22
18:38:39.000000000 +0800
+++ linux-2.6.21-rc6-git3/include/linux/pci_ids.h 2007-04-22
18:39:35.000000000 +0800
@@ -368,7 +368,6 @@
#define PCI_DEVICE_ID_ATI_IXP400_SATA 0x4379
#define PCI_DEVICE_ID_ATI_IXP400_SATA2 0x437a
#define PCI_DEVICE_ID_ATI_IXP600_SATA 0x4380
-#define PCI_DEVICE_ID_ATI_IXP600_SRAID 0x4381
#define PCI_DEVICE_ID_ATI_IXP600_SMBUS 0x4385
#define PCI_DEVICE_ID_ATI_IXP600_IDE 0x438
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ahci.c: remove non-existing SB600 raid id
2007-04-11 9:54 [PATCH] ahci.c: remove non-existing SB600 raid id Conke Hu
@ 2007-04-11 10:00 ` Tejun Heo
2007-04-11 10:12 ` Conke Hu
0 siblings, 1 reply; 4+ messages in thread
From: Tejun Heo @ 2007-04-11 10:00 UTC (permalink / raw)
To: Conke Hu; +Cc: Jeff Garzik, Alan, Linux Kernel Mailing List, linux-ide
Conke Hu wrote:
> SB600 RAID and SB600 SATA is the same controller and share the
> same PCI ID 0x4380. There is such PCI ID 0x4381.
I assume 'no' is missing in the last sentence. :-)
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ahci.c: remove non-existing SB600 raid id
2007-04-11 10:00 ` Tejun Heo
@ 2007-04-11 10:12 ` Conke Hu
2007-04-11 10:16 ` Tejun Heo
0 siblings, 1 reply; 4+ messages in thread
From: Conke Hu @ 2007-04-11 10:12 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jeff Garzik, Alan, Linux Kernel Mailing List, linux-ide
On 4/11/07, Tejun Heo <htejun@gmail.com> wrote:
> Conke Hu wrote:
> > SB600 RAID and SB600 SATA is the same controller and share the
> > same PCI ID 0x4380. There is such PCI ID 0x4381.
>
> I assume 'no' is missing in the last sentence. :-)
>
> --
> tejun
>
Oh, sorry :(
so, should I re-send the mail?
conke
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ahci.c: remove non-existing SB600 raid id
2007-04-11 10:12 ` Conke Hu
@ 2007-04-11 10:16 ` Tejun Heo
0 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2007-04-11 10:16 UTC (permalink / raw)
To: Conke Hu; +Cc: Jeff Garzik, Alan, Linux Kernel Mailing List, linux-ide
Conke Hu wrote:
> On 4/11/07, Tejun Heo <htejun@gmail.com> wrote:
>> Conke Hu wrote:
>> > SB600 RAID and SB600 SATA is the same controller and share the
>> > same PCI ID 0x4380. There is such PCI ID 0x4381.
>>
>> I assume 'no' is missing in the last sentence. :-)
>>
>> --
>> tejun
>>
>
> Oh, sorry :(
> so, should I re-send the mail?
It isn't my call but I think it's okay. I just couldn't resist the
bait. :-)
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-04-11 10:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-11 9:54 [PATCH] ahci.c: remove non-existing SB600 raid id Conke Hu
2007-04-11 10:00 ` Tejun Heo
2007-04-11 10:12 ` Conke Hu
2007-04-11 10:16 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox