From: "H. Peter Anvin" <hpa@zytor.com>
To: Egmont Koblinger <egmont@uhulinux.hu>
Cc: Jan Engelhardt <jengelh@linux01.gwdg.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] console UTF-8 fixes
Date: Thu, 12 Apr 2007 09:58:38 -0700 [thread overview]
Message-ID: <461E653E.6020400@zytor.com> (raw)
In-Reply-To: <20070412165540.GB21576@uhulinux.hu>
Egmont Koblinger wrote:
>
> We've arrived at another coding policy :)
>
> There are two possible behaviors, each have pros and cons. HPA prefers one,
> while Jan and me would prefer the other. The difference is one function that
> contains a large table and an invocation of that function in a small if
> branch.
>
> In my latest version of the patch I've put the function itself inside
> comments too. So it's not the real compiler, it's the preprocessor that
> omits this code for the default behavior. HPA, I hope you don't mind if the
> other reasonable behavior is there in the source, within comments. I think
> let's make the job easier for those who have a different opinion. Or is it a
> completely stupid idea?
>
Not leaving dead code in the kernel is long-standing policy; it's
nothing new. We constantly remove #if 0'd code that the authors have
left in.
-hpa
next prev parent reply other threads:[~2007-04-12 16:58 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 19:12 [PATCH] console UTF-8 fixes Egmont Koblinger
2007-04-06 19:43 ` H. Peter Anvin
2007-04-07 9:24 ` Egmont Koblinger
2007-04-07 11:00 ` Jan Engelhardt
2007-04-07 17:26 ` Egmont Koblinger
2007-04-07 17:59 ` H. Peter Anvin
2007-04-10 9:43 ` Egmont Koblinger
2007-04-10 15:43 ` H. Peter Anvin
2007-04-10 17:19 ` Egmont Koblinger
2007-04-10 17:30 ` H. Peter Anvin
2007-04-10 18:51 ` Egmont Koblinger
2007-04-11 12:58 ` Jan Engelhardt
2007-04-10 17:36 ` Alan Cox
2007-04-10 17:36 ` H. Peter Anvin
2007-04-11 18:28 ` Egmont Koblinger
2007-04-11 18:36 ` H. Peter Anvin
2007-04-12 9:11 ` Egmont Koblinger
2007-04-12 15:36 ` H. Peter Anvin
2007-04-12 16:41 ` Jan Engelhardt
2007-04-12 16:55 ` Egmont Koblinger
2007-04-12 16:58 ` H. Peter Anvin [this message]
2007-04-12 17:16 ` Egmont Koblinger
2007-04-12 17:35 ` H. Peter Anvin
2007-04-12 17:44 ` Egmont Koblinger
2007-04-12 17:49 ` H. Peter Anvin
2007-04-12 18:46 ` Jan Engelhardt
2007-04-12 12:54 ` Egmont Koblinger
2007-04-12 13:13 ` Alan Cox
2007-04-12 14:06 ` Egmont Koblinger
2007-04-12 14:38 ` Roman Zippel
2007-04-12 14:58 ` Egmont Koblinger
2007-04-12 15:52 ` Roman Zippel
2007-04-12 16:36 ` Egmont Koblinger
2007-04-12 18:09 ` Roman Zippel
2007-04-11 19:00 ` Jan Engelhardt
2007-04-12 9:22 ` Egmont Koblinger
2007-04-11 19:36 ` Pavel Machek
2007-04-12 8:14 ` Jan Engelhardt
-- strict thread matches above, loose matches on Subject: below --
2007-04-17 10:22 Egmont Koblinger
2007-06-19 12:13 ` Egmont Koblinger
[not found] <8aT6Q-3iM-17@gated-at.bofh.it>
[not found] ` <8xLa7-25v-5@gated-at.bofh.it>
2007-06-19 13:54 ` Bodo Eggert
2007-06-19 14:42 ` Egmont Koblinger
2007-06-19 17:10 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461E653E.6020400@zytor.com \
--to=hpa@zytor.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=egmont@uhulinux.hu \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox