From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1751110AbXDLRfq@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751110AbXDLRfq (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 Apr 2007 13:35:46 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751197AbXDLRfq
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 12 Apr 2007 13:35:46 -0400
Received: from terminus.zytor.com ([192.83.249.54]:58364 "EHLO
	terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751110AbXDLRfp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 Apr 2007 13:35:45 -0400
Message-ID: <461E6DDC.7050202@zytor.com>
Date: Thu, 12 Apr 2007 10:35:24 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Thunderbird 1.5.0.10 (X11/20070302)
MIME-Version: 1.0
To: Egmont Koblinger <egmont@uhulinux.hu>
CC: Jan Engelhardt <jengelh@linux01.gwdg.de>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] console UTF-8 fixes
References: <461BB092.3070201@zytor.com> <20070410171924.GA18314@uhulinux.hu> <20070410183659.7341eeec@the-village.bc.nu> <20070411182801.GC26382@uhulinux.hu> <461D2AB8.5080902@zytor.com> <20070412091120.GA15666@uhulinux.hu> <461E5212.8070807@zytor.com> <Pine.LNX.4.61.0704121840350.14441@yvahk01.tjqt.qr> <20070412165540.GB21576@uhulinux.hu> <461E653E.6020400@zytor.com> <20070412171606.GA24756@uhulinux.hu>
In-Reply-To: <20070412171606.GA24756@uhulinux.hu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

Egmont Koblinger wrote:
> On Thu, Apr 12, 2007 at 09:58:38AM -0700, H. Peter Anvin wrote:
> 
>> Not leaving dead code in the kernel is long-standing policy; it's 
>> nothing new.  We constantly remove #if 0'd code that the authors have 
>> left in.
> 
> I see. However, you wrote it recently:
> 
>> Besides, would it not make more sense to have a single table with the
>> width information, if you insist on having one, instead of multiple ones?
> 
> If I rework the code according to this then the zero-width information will
> no longer be dead code, right? The unchanged kernel would be slightly larger
> and would run slightly slower, but it would be much easier to patch it to
> reach the other possible behavior regarding combining characters.
> 

Yes, I didn't realize at the time that that was dead code.

	-hpa