From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753736AbXDMRVy (ORCPT ); Fri, 13 Apr 2007 13:21:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753740AbXDMRVy (ORCPT ); Fri, 13 Apr 2007 13:21:54 -0400 Received: from gw.goop.org ([64.81.55.164]:51747 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753647AbXDMRVy (ORCPT ); Fri, 13 Apr 2007 13:21:54 -0400 Message-ID: <461FBC0D.5060603@goop.org> Date: Fri, 13 Apr 2007 10:21:17 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Hugh Dickins CC: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH mm] fix i386 get_gate_vma oops References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hugh Dickins wrote: > Fix oops from i386-make-compat_vdso-runtime-selectable.patch. > > Even mingetty at system startup finds it easy to trigger an oops > while reading /proc/PID/maps: though it has a good hold on the mm > itself, that cannot stop exit_mm() from resetting tsk->mm to NULL. > > (It is usually show_map()'s call to get_gate_vma() which oopses, > and I expect we could change that to check priv->tail_vma instead; > but no matter, even m_start()'s call just after get_task_mm() is racy.) > > Signed-off-by: Hugh Dickins > Hm, OK. Acked-by: Jeremy Fitzhardinge J