From: "H. Peter Anvin" <hpa@zytor.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Zachary Amsden <zach@vmware.com>,
Chris Wright <chrisw@sous-sol.org>, Andi Kleen <ak@suse.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Crash while mapping memory in pagetable_init() (Was: Re: .config)
Date: Fri, 13 Apr 2007 13:42:46 -0700 [thread overview]
Message-ID: <461FEB46.3000702@zytor.com> (raw)
In-Reply-To: <461FE9D1.1000803@goop.org>
Jeremy Fitzhardinge wrote:
> H. Peter Anvin wrote:
>> I suggest, for clarity and to minimize bloat:
>
> I think it would save a page, at most. But OK. (Also, if you're
> running !PAE, these pages will actually become part of the init_mm
> pagetable, so there's no memory wastage at all.)
Even with PSE?
However, the main reason I wanted it done that way is to avoid cargo
cult programming; this makes it much clearer where the numbers actually
come from.
>> #ifdef CONFIG_X86_PAE
>> # define PAGE_TABLE_SIZE ((2048+4)*4096)
>> #else
>> # define PAGE_TABLE_SIZE ((1024+1)*4096)
>
> 1024 should be enough; the pgd is still swapper_pg_dir, and there are no
> pmds.
Check.
-hpa
next prev parent reply other threads:[~2007-04-13 20:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070413174913.GA25234@ezr.goop.org>
[not found] ` <20070413183841.GP10574@sequoia.sous-sol.org>
[not found] ` <20070413190552.GQ10574@sequoia.sous-sol.org>
[not found] ` <461FD97B.1010203@goop.org>
2007-04-13 20:09 ` Crash while mapping memory in pagetable_init() (Was: Re: .config) Zachary Amsden
2007-04-13 20:12 ` Jeremy Fitzhardinge
2007-04-13 20:26 ` H. Peter Anvin
2007-04-13 20:27 ` Jeremy Fitzhardinge
2007-04-13 20:32 ` H. Peter Anvin
2007-04-13 20:36 ` Jeremy Fitzhardinge
2007-04-13 20:42 ` H. Peter Anvin [this message]
2007-04-13 21:05 ` Jeremy Fitzhardinge
2007-04-13 21:12 ` H. Peter Anvin
2007-04-14 0:10 ` Chris Wright
2007-04-13 20:37 ` H. Peter Anvin
2007-04-13 21:07 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461FEB46.3000702@zytor.com \
--to=hpa@zytor.com \
--cc=ak@suse.de \
--cc=chrisw@sous-sol.org \
--cc=ebiederm@xmission.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox