From: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
To: Colin King <colin.king@canonical.com>,
dl-esc-Aacraid Linux Driver <aacraid@microsemi.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH][scsi-next] scsi: aacraid: remove redundant setting of variable c
Date: Fri, 5 Jan 2018 16:42:25 +0000 [thread overview]
Message-ID: <461db48ecc3c479c9789340bf3608e8b@microsemi.com> (raw)
In-Reply-To: <20180105153106.17605-1-colin.king@canonical.com>
> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: Friday, January 5, 2018 7:31 AM
> To: dl-esc-Aacraid Linux Driver <aacraid@microsemi.com>; James E . J .
> Bottomley <jejb@linux.vnet.ibm.com>; Martin K . Petersen
> <martin.petersen@oracle.com>; linux-scsi@vger.kernel.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH][scsi-next] scsi: aacraid: remove redundant setting of
> variable c
>
> EXTERNAL EMAIL
>
>
> From: Colin Ian King <colin.king@canonical.com>
>
> A previous commit no longer stores the contents of c, so we now have
> a situation where c is being updated but the value is never read. Clean
> up the code by removing the now redundant setting of variable c.
>
> Cleans up clang warning:
> drivers/scsi/aacraid/aachba.c:943:3: warning: Value stored to 'c' is
> never read
>
> Fixes: f4e8708d3104 ("scsi: aacraid: Fix udev inquiry race condition")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Reviewed-by :Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
next prev parent reply other threads:[~2018-01-05 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 15:31 [PATCH][scsi-next] scsi: aacraid: remove redundant setting of variable c Colin King
2018-01-05 16:42 ` Raghava Aditya Renukunta [this message]
2018-01-09 2:50 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461db48ecc3c479c9789340bf3608e8b@microsemi.com \
--to=raghavaaditya.renukunta@microsemi.com \
--cc=aacraid@microsemi.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox