public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: drraid@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: Kernel 2.6.20.4 Unaligned address
Date: Sat, 14 Apr 2007 19:16:50 +0200	[thread overview]
Message-ID: <46210C82.6060701@trash.net> (raw)
In-Reply-To: <20070413.163521.45883605.davem@davemloft.net>

David Miller wrote:
> From: "doctor raid" <drraid@gmail.com>
> Date: Tue, 10 Apr 2007 16:02:01 -0700
> 
> 
>>[1] kernel errors reporting unaligned access of memory
>>[2]  The following two lines iterate twice a piece, about once every 2 minutes:
>>
>>      Kernel unaligned access at TPC[79c344] arpt_do_table+0x3cc/0x640
>>       Kernel unaligned access at TPC[79c33c] arpt_do_table+0x3c4/0x640
> 
> 
> This patch below should fix this problem.
> 
> Patrick I'm going to push this to Linus.  Even if it doesn't
> fix this person's problem, either both the input device loop
> and the output device loop should use the "long" casting
> optimization or both should not :-)


Looks good, thanks Dave. On 64 bit both interfaces are unaligned
within struct arpt_arp:

char                       iniface[16];          /*    94    16 */
char                       outiface[16];         /*   110    16 */

      reply	other threads:[~2007-04-14 17:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-10 23:02 Kernel 2.6.20.4 Unaligned address doctor raid
2007-04-10 23:06 ` David Miller
2007-04-11  6:35   ` Mathieu Chouquet-Stringer
2007-04-13 23:35 ` David Miller
2007-04-14 17:16   ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46210C82.6060701@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=drraid@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox