From: Richard Weinberger <richard@nod.at>
To: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Sabyasachi Gupta <sabyasachi.linux@gmail.com>,
jdike@addtoit.com, yuehaibing@huawei.com,
brajeswar.linux@gmail.com, linux-um@lists.infradead.org,
jrdr.linux@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] um: Remove duplicate headers
Date: Fri, 18 Jan 2019 20:42:13 +0100 [thread overview]
Message-ID: <4621128.kXzvTGAT2u@blindfold> (raw)
In-Reply-To: <dfdf5e70-f782-d90e-1059-a524a5e72b7d@cambridgegreys.com>
Am Freitag, 18. Januar 2019, 20:23:07 CET schrieb Anton Ivanov:
>
> On 18/01/2019 14:58, Sabyasachi Gupta wrote:
> > Remove sys/socket.h and sys/uio.h which are included more than once
> >
> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> > ---
> > arch/um/drivers/vector_user.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/um/drivers/vector_user.c b/arch/um/drivers/vector_user.c
> > index d2c17dd..c863921 100644
> > --- a/arch/um/drivers/vector_user.c
> > +++ b/arch/um/drivers/vector_user.c
> > @@ -23,7 +23,6 @@
> > #include <netinet/ether.h>
> > #include <linux/if_ether.h>
> > #include <linux/if_packet.h>
> > -#include <sys/socket.h>
> > #include <sys/wait.h>
> > #include <sys/uio.h>
> > #include <linux/virtio_net.h>
> > @@ -31,7 +30,6 @@
> > #include <stdlib.h>
> > #include <os.h>
> > #include <um_malloc.h>
> > -#include <sys/uio.h>
> > #include "vector_user.h"
> >
> > #define ID_GRE 0
> >
>
> Hi Sabyasachi,
>
> I believe we have an identical patch enqueued already from a couple of
> weeks back.
Hmm, did I miss that one in patchwork?
Thanks,
//richard
next prev parent reply other threads:[~2019-01-18 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 14:58 [PATCH] um: Remove duplicate headers Sabyasachi Gupta
2019-01-18 19:23 ` Anton Ivanov
2019-01-18 19:42 ` Richard Weinberger [this message]
2019-01-18 20:00 ` Anton Ivanov
2019-01-18 21:54 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4621128.kXzvTGAT2u@blindfold \
--to=richard@nod.at \
--cc=anton.ivanov@cambridgegreys.com \
--cc=brajeswar.linux@gmail.com \
--cc=jdike@addtoit.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=sabyasachi.linux@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox