Re: [patch] use C99 initialisers for PCI_VDEVICE()

Ulrich Eckhardt
2007-04-15T13:31:30Z

On Sunday 15 April 2007 14:53, Jeff Garzik wrote:
> Ulrich Eckhardt wrote:
> > (Note: CC me please, I'm not subscribed.)
[...]
> > -#define PCI_VDEVICE(vendor, device) \
> > - PCI_VENDOR_ID_##vendor, (device), \
> > - PCI_ANY_ID, PCI_ANY_ID, 0, 0
> > +#define PCI_VDEVICE(vend, dev) \
> > + .vendor=PCI_VENDOR_ID_##vend, .device=(dev), \
> > + .subvendor=PCI_ANY_ID, .subdevice=PCI_ANY_ID, \
> > + .class=0, .class_mask=0
>
> NAK. C99 initializers were intentionally avoided. Look at the usage of
> this macro.

I'm aware of the uses and documentation of this, I was just under the
impression that C99 initialisers were the agreed way to go because of their
resistance against reording of fields. Of course, if that assumption is
wrong, this patch is moot anyway.

Am I generally wrong or is this case an intentional exception?

Uli