Re: [patch] use C99 initialisers for PCI_VDEVICE()

Jeff Garzik
2007-04-15T12:53:47Z

Ulrich Eckhardt wrote:
> (Note: CC me please, I'm not subscribed.)
>
> Not much to say about the patch (it's against 2.6.20.6), it just converts a
> macro to generate C99-style initialisers.
>
> --- include/linux/pci.h (revision 17)
> +++ include/linux/pci.h (working copy)
> @@ -407,9 +407,10 @@
> * private data.
> */
>
> -#define PCI_VDEVICE(vendor, device) \
> - PCI_VENDOR_ID_##vendor, (device), \
> - PCI_ANY_ID, PCI_ANY_ID, 0, 0
> +#define PCI_VDEVICE(vend, dev) \
> + .vendor=PCI_VENDOR_ID_##vend, .device=(dev), \
> + .subvendor=PCI_ANY_ID, .subdevice=PCI_ANY_ID, \
> + .class=0, .class_mask=0

NAK. C99 initializers were intentionally avoided. Look at the usage of
this macro.

Jeff