* [PATCH] [ALSA] Add first generation macbook subsystem ID
@ 2007-04-17 4:31 bainonline
2007-04-17 9:59 ` [alsa-devel] " Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: bainonline @ 2007-04-17 4:31 UTC (permalink / raw)
To: perex, linux-kernel, alsa-devel; +Cc: Abhijit Bhopatkar
From: Abhijit Bhopatkar <bainonline@gmail.com>
First generation MacBooks were getting ignored by sigmatel drivers
and wrongly being identified as MACMINI. This patch makes them
identify as MACBOOK.
Signed-off-by: Abhijit Bhopatkar <bainonline@gmail.com>
---
sound/pci/hda/patch_sigmatel.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index c94291b..cb99df5 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -1905,6 +1905,9 @@ static int patch_stac922x(struct hda_codec *codec)
*/
printk(KERN_INFO "hda_codec: STAC922x, Apple subsys_id=%x\n", codec->subsystem_id);
switch (codec->subsystem_id) {
+ case 0x106b0a00: /* MacBook First generatoin */
+ spec->board_config = STAC_MACBOOK;
+ break;
case 0x106b0200: /* MacBook Pro first generation */
spec->board_config = STAC_MACBOOK_PRO_V1;
break;
--
1.4.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [alsa-devel] [PATCH] [ALSA] Add first generation macbook subsystem ID
2007-04-17 4:31 [PATCH] [ALSA] Add first generation macbook subsystem ID bainonline
@ 2007-04-17 9:59 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2007-04-17 9:59 UTC (permalink / raw)
To: bainonline; +Cc: perex, linux-kernel, alsa-devel
At Tue, 17 Apr 2007 10:01:47 +0530,
bainonline@gmail.com wrote:
>
> From: Abhijit Bhopatkar <bainonline@gmail.com>
>
> First generation MacBooks were getting ignored by sigmatel drivers
> and wrongly being identified as MACMINI. This patch makes them
> identify as MACBOOK.
>
> Signed-off-by: Abhijit Bhopatkar <bainonline@gmail.com>
This actually doesn't change behavior at all (both mac mini and mac
book use the same pin configs), but it's still nice to add ID if any
specific fix would be needed in future.
Applied to ALSA tree now. Thanks.
Takashi
> ---
> sound/pci/hda/patch_sigmatel.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index c94291b..cb99df5 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -1905,6 +1905,9 @@ static int patch_stac922x(struct hda_codec *codec)
> */
> printk(KERN_INFO "hda_codec: STAC922x, Apple subsys_id=%x\n", codec->subsystem_id);
> switch (codec->subsystem_id) {
> + case 0x106b0a00: /* MacBook First generatoin */
> + spec->board_config = STAC_MACBOOK;
> + break;
> case 0x106b0200: /* MacBook Pro first generation */
> spec->board_config = STAC_MACBOOK_PRO_V1;
> break;
> --
> 1.4.4.2
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-17 9:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-17 4:31 [PATCH] [ALSA] Add first generation macbook subsystem ID bainonline
2007-04-17 9:59 ` [alsa-devel] " Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox