* why UDF have so ugly filesize limit?
@ 2007-04-19 13:55 Marat Buharov
2007-04-19 16:56 ` Chuck Ebbert
2007-04-20 20:52 ` Jan Kara
0 siblings, 2 replies; 5+ messages in thread
From: Marat Buharov @ 2007-04-19 13:55 UTC (permalink / raw)
To: linux-kernel
from fs/udf/super.c:
in function udf_fill_super
sb->s_maxbytes = 1<<30; (1 GB)
Why sb->s_maxbytes is not equal to MAX_LFS_FILESIZE?
So, in include/linux/fs.h written that the filesystems should put that
(MAX_LFS_FILESIZE) into their s_maxbytes, otherwise bad things can
happen in VM.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: why UDF have so ugly filesize limit?
2007-04-19 13:55 why UDF have so ugly filesize limit? Marat Buharov
@ 2007-04-19 16:56 ` Chuck Ebbert
2007-04-19 17:12 ` Alan Cox
2007-04-20 20:52 ` Jan Kara
1 sibling, 1 reply; 5+ messages in thread
From: Chuck Ebbert @ 2007-04-19 16:56 UTC (permalink / raw)
To: Marat Buharov; +Cc: linux-kernel
Marat Buharov wrote:
> from fs/udf/super.c:
> in function udf_fill_super
> sb->s_maxbytes = 1<<30; (1 GB)
>
> Why sb->s_maxbytes is not equal to MAX_LFS_FILESIZE?
>
Patches to fix that are in the -mm kernel already (and in
Fedora Core 6 latest update.)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: why UDF have so ugly filesize limit?
2007-04-19 16:56 ` Chuck Ebbert
@ 2007-04-19 17:12 ` Alan Cox
2007-04-19 17:15 ` Chuck Ebbert
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2007-04-19 17:12 UTC (permalink / raw)
To: Chuck Ebbert; +Cc: Marat Buharov, linux-kernel
On Thu, 19 Apr 2007 12:56:27 -0400
Chuck Ebbert <cebbert@redhat.com> wrote:
> Marat Buharov wrote:
> > from fs/udf/super.c:
> > in function udf_fill_super
> > sb->s_maxbytes = 1<<30; (1 GB)
> >
> > Why sb->s_maxbytes is not equal to MAX_LFS_FILESIZE?
> >
>
> Patches to fix that are in the -mm kernel already (and in
> Fedora Core 6 latest update.)
Good to know, presumably these also fix the underlying UDF problems in the
UDF filesystem code that caused it to be put there in the first pace ?
(Security CVE-2006-4145)
Alan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: why UDF have so ugly filesize limit?
2007-04-19 17:12 ` Alan Cox
@ 2007-04-19 17:15 ` Chuck Ebbert
0 siblings, 0 replies; 5+ messages in thread
From: Chuck Ebbert @ 2007-04-19 17:15 UTC (permalink / raw)
To: Alan Cox; +Cc: Marat Buharov, linux-kernel
Alan Cox wrote:
> On Thu, 19 Apr 2007 12:56:27 -0400
> Chuck Ebbert <cebbert@redhat.com> wrote:
>
>> Marat Buharov wrote:
>>> from fs/udf/super.c:
>>> in function udf_fill_super
>>> sb->s_maxbytes = 1<<30; (1 GB)
>>>
>>> Why sb->s_maxbytes is not equal to MAX_LFS_FILESIZE?
>>>
>> Patches to fix that are in the -mm kernel already (and in
>> Fedora Core 6 latest update.)
>
> Good to know, presumably these also fix the underlying UDF problems in the
> UDF filesystem code that caused it to be put there in the first pace ?
>
> (Security CVE-2006-4145)
Yeah, the patches are by Jan Kara who put the original limitation
in there as a temporary band-aid.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: why UDF have so ugly filesize limit?
2007-04-19 13:55 why UDF have so ugly filesize limit? Marat Buharov
2007-04-19 16:56 ` Chuck Ebbert
@ 2007-04-20 20:52 ` Jan Kara
1 sibling, 0 replies; 5+ messages in thread
From: Jan Kara @ 2007-04-20 20:52 UTC (permalink / raw)
To: Marat Buharov; +Cc: linux-kernel
> from fs/udf/super.c:
> in function udf_fill_super
> sb->s_maxbytes = 1<<30; (1 GB)
>
> Why sb->s_maxbytes is not equal to MAX_LFS_FILESIZE?
Because UDF had some flaws and user could crash a kernel with larger
filesize. In -mm kernel are patches fixing the flaw and also raising the
limit back to MAX_LFS_FILESIZE.
> So, in include/linux/fs.h written that the filesystems should put that
> (MAX_LFS_FILESIZE) into their s_maxbytes, otherwise bad things can
> happen in VM.
Bad things can happen only if you set it to more than
MAX_LFS_FILESIZE. With smaller values only users are disappointed ;).
Honza
--
Jan Kara <jack@suse.cz>
SuSE CR Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-04-20 20:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-19 13:55 why UDF have so ugly filesize limit? Marat Buharov
2007-04-19 16:56 ` Chuck Ebbert
2007-04-19 17:12 ` Alan Cox
2007-04-19 17:15 ` Chuck Ebbert
2007-04-20 20:52 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox