From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1766910AbXDSRzF (ORCPT ); Thu, 19 Apr 2007 13:55:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1766913AbXDSRzF (ORCPT ); Thu, 19 Apr 2007 13:55:05 -0400 Received: from mtaout1.012.net.il ([84.95.2.1]:41076 "EHLO mtaout1.012.net.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1766910AbXDSRzE (ORCPT ); Thu, 19 Apr 2007 13:55:04 -0400 Date: Thu, 19 Apr 2007 20:54:55 +0300 From: Avi Kivity Subject: Re: [RFC 6/8] Account for pages in the page cache in terms of base pages In-reply-to: To: Christoph Lameter Cc: Nish Aravamudan , linux-kernel@vger.kernel.org, Peter Zijlstra , Nick Piggin , Andi Kleen , Paul Jackson , Dave Chinner Message-id: <4627ACEF.8060605@argo.co.il> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7BIT X-Enigmail-Version: 0.94.3.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.1.12 (firebolt.argo.co.il [0.0.0.0]); Thu, 19 Apr 2007 20:54:55 +0300 (IDT) References: <20070419163504.11948.58487.sendpatchset@schroedinger.engr.sgi.com> <20070419163535.11948.91100.sendpatchset@schroedinger.engr.sgi.com> <29495f1d0704191045u77e8d7e1g87954549b82a0306@mail.gmail.com> User-Agent: Thunderbird 1.5.0.10 (X11/20070302) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Christoph Lameter wrote: > On Thu, 19 Apr 2007, Nish Aravamudan wrote: > > >>> NR_FILE_PAGES, >>> + 1 << mappig->order); >>> >> Typo? should be mapping->order? >> > > Correct. Sigh. Why do these things creep in at the last minute before > posting??? > To make sure you know that somebody's read them? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.