From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1766972AbXDSTpE (ORCPT ); Thu, 19 Apr 2007 15:45:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1766976AbXDSTpE (ORCPT ); Thu, 19 Apr 2007 15:45:04 -0400 Received: from gw.goop.org ([64.81.55.164]:38095 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1766972AbXDSTpB (ORCPT ); Thu, 19 Apr 2007 15:45:01 -0400 Message-ID: <4627C6B9.7000605@goop.org> Date: Thu, 19 Apr 2007 12:44:57 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Matt Mackall CC: Andi Kleen , Andrew Morton , virtualization@lists.osdl.org, lkml , Ian Pratt , Christian Limpach , Chris Wright , Christoph Lameter , Matt Mackall , Ingo Molnar Subject: Re: [patch 20/20] Add apply_to_page_range() which applies a function to a pte range. References: <20070404191151.009821039@goop.org> <20070404191206.675793431@goop.org> <20070405044133.GE4892@waste.org> <46149CC9.2070903@goop.org> <20070417205652.GM11115@waste.org> In-Reply-To: <20070417205652.GM11115@waste.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Matt Mackall wrote: > I think adding a flags field and an allocate flag to my callback > struct would be sufficient here. > Yes, probably. What about something that wants to shatter superpages? > The syntax is horrible, but I don't think we end up using the > resultant type enough to justify the namespace pollution. > Don't know that that's a huge concern. The typedef namespace (*_t) is pretty empty, and its not like we're talking about something that's visible outside the kernel. And the syntax is *really* ugly. J