From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1767008AbXDSVh5 (ORCPT ); Thu, 19 Apr 2007 17:37:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1767007AbXDSVh5 (ORCPT ); Thu, 19 Apr 2007 17:37:57 -0400 Received: from gw.goop.org ([64.81.55.164]:44496 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1767006AbXDSVh4 (ORCPT ); Thu, 19 Apr 2007 17:37:56 -0400 Message-ID: <4627E131.5070801@goop.org> Date: Thu, 19 Apr 2007 14:37:53 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Matt Mackall CC: Andi Kleen , Andrew Morton , virtualization@lists.osdl.org, lkml , Ian Pratt , Christian Limpach , Chris Wright , Christoph Lameter , Matt Mackall , Ingo Molnar Subject: Re: [patch 20/20] Add apply_to_page_range() which applies a function to a pte range. References: <20070404191151.009821039@goop.org> <20070404191206.675793431@goop.org> <20070405044133.GE4892@waste.org> <46149CC9.2070903@goop.org> <20070417205652.GM11115@waste.org> <4627C6B9.7000605@goop.org> <20070419195957.GF11115@waste.org> In-Reply-To: <20070419195957.GF11115@waste.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Matt Mackall wrote: > Haven't thought a huge amount about that. Perhaps it's best done with > the level 3 callback? > Level 2, I think, assuming you count the pte pages as level 1. I think it can be dealt with, so long as it correctly skips level 1 callbacks for superpages, and does the test after the level 2 callback has returned. J