From: "Jan Beulich" <jbeulich@novell.com>
To: "Adrian Bunk" <bunk@stusta.de>
Cc: <linux-pci@atrey.karlin.mff.cuni.cz>,
"Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>,
"Marcos Pinto" <markybob@gmail.com>, "Alan Cox" <alan@redhat.com>,
"Greg KH" <gregkh@suse.de>, <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.20.7 locking up hard on boot
Date: Mon, 23 Apr 2007 09:06:29 +0100 [thread overview]
Message-ID: <462C8525.76E4.0078.0@novell.com> (raw)
In-Reply-To: <20070421103632.GC4016@stusta.de>
>Considering where it failed and that 2.6.20.3 worked, I would be
>extremely surprised if this wasn't one more report of
>adjust-legacy-ide-resource-setting.patch breaking booting (and we
>already have confirmed reports for this)...
>
>But AFAIK we still don't understand how this patch managed to break
>things.
Given that all of the reports are in cases when the adjustment is *not*
being done (and only a message is being printed), I can only assume that
the breakage results from the adding of PCI_BASE_ADDRESS_SPACE_IO
into the resource flags. I considered this unconditional setting of the flags
odd already in the original code, and added this extra flag only for
consistency reasons (because the settings reported by X indicated that
this was missing). Perhaps the adjustment (original and the added
extra flag) shouldn't be done if IORESOURCE_IO wasn't already set.
Perhaps one of those seeing the issue could try out returning from the
function right after that printk(), without any adjustment to the flags.
Jan
next prev parent reply other threads:[~2007-04-23 8:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-21 0:47 2.6.20.7 locking up hard on boot Marcos Pinto
2007-04-21 1:34 ` Adrian Bunk
2007-04-21 4:30 ` Marcos Pinto
2007-04-21 5:34 ` Greg KH
2007-04-21 10:36 ` Adrian Bunk
2007-04-21 10:54 ` Marcos Pinto
2007-04-22 2:00 ` Len Brown
2007-04-21 12:44 ` Bartlomiej Zolnierkiewicz
2007-04-23 8:06 ` Jan Beulich [this message]
2007-04-23 22:58 ` Marcos Pinto
2007-04-24 19:11 ` Marcos Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462C8525.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=alan@redhat.com \
--cc=bunk@stusta.de \
--cc=bzolnier@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=markybob@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox