From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Hugh Dickins <hugh@veritas.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: PageLRU can be non-atomic bit operation
Date: Tue, 24 Apr 2007 20:13:15 +1000 [thread overview]
Message-ID: <462DD83B.40708@yahoo.com.au> (raw)
In-Reply-To: <6.0.0.20.2.20070424165007.04921fd8@172.19.0.2>
Hisashi Hifumi wrote:
>
> At 11:47 07/04/24, Nick Piggin wrote:
>
> >As Hugh points out, we must have atomic ops here, so changing the generic
> >code to use the __ version is wrong. However if there is a faster way
> that
> >i386 can perform the atomic variant, then doing so will speed up the
> generic
> >code without breaking other architectures.
> >
>
> Do you mean writing page-flags.h specific for i386 so improving generic
> code
> and without breaking other architectures ?
I meant improving the i386 bitops specific code.
However if there is some variant of operation that is not captured
with the current bitop API, but could provide a useful speedup of
common page flag manipulations, then you might consider extending
the bitop API and making page-flags.h use that new operation.
--
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2007-04-24 10:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 10:54 [PATCH] mm: PageLRU can be non-atomic bit operation Hisashi Hifumi
2007-04-23 11:16 ` Hugh Dickins
2007-04-23 12:34 ` Hisashi Hifumi
2007-04-23 13:42 ` Hugh Dickins
2007-04-24 1:54 ` Hisashi Hifumi
2007-04-24 2:29 ` KAMEZAWA Hiroyuki
2007-04-24 2:47 ` Nick Piggin
2007-04-24 8:12 ` Hisashi Hifumi
2007-04-24 10:13 ` Nick Piggin [this message]
2007-04-24 13:40 ` Hugh Dickins
2007-04-24 14:22 ` Andi Kleen
2007-04-25 8:56 ` Fernando Luis Vázquez Cao
2007-04-25 8:59 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462DD83B.40708@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@linux-foundation.org \
--cc=hifumi.hisashi@oss.ntt.co.jp \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox