From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754112AbXDZCh6 (ORCPT ); Wed, 25 Apr 2007 22:37:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754632AbXDZCh6 (ORCPT ); Wed, 25 Apr 2007 22:37:58 -0400 Received: from rgminet01.oracle.com ([148.87.113.118]:21386 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754112AbXDZCh5 (ORCPT ); Wed, 25 Apr 2007 22:37:57 -0400 Message-ID: <4630109F.6090002@oracle.com> Date: Wed, 25 Apr 2007 19:38:23 -0700 From: Randy Dunlap User-Agent: Thunderbird 1.5.0.5 (X11/20060719) MIME-Version: 1.0 To: Dave Jones , Andrew Morton , Randy Dunlap , Martin Schwidefsky , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, mb@bu3sch.de, linville@tuxdriver.com, arnd@arndb.de, maxextreme@gmail.com, gregkh@suse.de Subject: Re: [PATCH 0/9] Kconfig: cleanup s390 v2. References: <20070423141123.GA21174@skybase> <20070423104534.51bac974.akpm@linux-foundation.org> <20070425112133.4ae86399.randy.dunlap@oracle.com> <20070425143011.57247c1d.akpm@linux-foundation.org> <20070425172447.1576c399.akpm@linux-foundation.org> <20070426003911.GA19383@redhat.com> In-Reply-To: <20070426003911.GA19383@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Dave Jones wrote: > On Wed, Apr 25, 2007 at 05:24:47PM -0700, Andrew Morton wrote: > > > It would be neat if someone could create and maintain a new > > scripts/spot-common-mistakes. Feed it a unified diff and it would complain > > about newly-added code (and only newly-added code) which has busted > > whitespace, adds new semaphores, adds new kernel_thread calls, etc, etc. > > years and years ago, when the dinosaurs roamed the land, I hacked up.. > http://janitor.kernelnewbies.org/scripts/ and then left it by the wayside. > Some of the checks it did are actually bogus, but I'm happy to pick that > up again if there's interest in it being a useful tool. > > In fact, I should probably munge it together with a similar thing > I wrote at http://www.codemonkey.org.uk/projects/findbugs/ > (Warning: scary regexps) > > > It would need to be fairly simple and easily-extensible, as I can > > imagine quite a few things getting added to it. > > > > (Imagines a procmail rule which just bounces the email if > > spot-common-mistakes failed) > > or a git checkin rule that refuses to commit if it fails ;-) Yep, I was going to mention your scripts but you beat me to it. I'll be glad to help maintain such animals if wanted. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***