Re: [PATCH] i386: For debugging, make the initial page table setup less forgiving.

Eric W. Biederman
2007-04-25T19:02:26Z

Jeremy Fitzhardinge <jeremy@goop.org> writes:

> I might have introduced it as part of the paravirt_ops patches. When
> setting up pagetables under Xen, we need to make sure we preserve the
> initial mappings Xen put in place (it starts the VM with paging enabled,
> and a sane initial pagetable). This may have leaked over into native if
> it doesn't replace an existing entry.

Yes in paravirt_ops-hooks-to-set-up-initial-pagetable
Grr. That is what I get for trying to avoid conflicts by working
against the -mm tree.

I thought that code had been like that for a while. Since it hasn't
been merged upstream it looks to me like that patch needs to be fixed.
And we can keep HPA debugging patch.

> Hm, but it should be overwriting small mappings with large ones. Maybe
> I overlooked that.

Nope. It's not overwriting anything. I'm not at all convinced we
should preserve the Xen sillyness. I'm not exactly against it,
but it adds complexity to already complex code.

>> I'm halfway through putting together a patchset to address a
>> bunch of these.
>>
>> I haven't yet resolved how I want to allocate the pages for the
>> identity mapping of the page table yet. I can't use the bootmem
>> allocate as it exists because that assumes the page is mapped
>> into the address space already.
>>
>
> Are you going to clash horribly with the paravirt pagetable setup? We
> should probably coordinate if so.

We will have to see. Currently the paravirt pagetable setup clashes
horrible with actually running a kernel on real hardware.

Color me not impressed by the paravirt mess.

Eric