Re: [PATCH] i386: For debugging, make the initial page table setup less forgiving.

Eric W. Biederman
2007-04-25T22:27:59Z

Jeremy Fitzhardinge <jeremy@goop.org> writes:

> Eric W. Biederman wrote:
>> Nope. It's not overwriting anything.
>
> This should fix it.
>
> Subject: x86: fix PSE pagetable construction
>
> When constructing the initial pagetable in pagetable_init, make sure
> that non-PSE pmds are updated to PSE ones.
>
> This moves the definition of pmd_huge() out of the hugetlbfs files
> into pgtable.h.

No. Please just remove the conditionals on the leaf pages.
We know exactly what we require them to be, there is minimal
cost and no downside to just setting the pte entries to
what we want them to be for the identity mapping.

It doesn't make sense for paravirtualization or anything else to
influence that.

This may be redoing work that has been done before but it is
doing it all one common place.

It does make sense not to overwrite the intermediate pages.

Not overwriting intermediate pages is reasonable, and allows
other things to be going on and to be preserved.

Eric