Re: [00/17] Large Blocksize Support V3

Christoph Lameter
2007-04-27T12:01:44Z

On Fri, 27 Apr 2007, Andrew Morton wrote:

> On Fri, 27 Apr 2007 00:19:49 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:
>
> > The page cache handling in the various layers is significantly
> > simplified which reduces maintenance cost.
>
> How on earth can the *addition* of variable pagecache size simplify the
> existing code?

Because the page cache code is full of manual shifts and adds. Its a mess.
Adding appropriate accessors simplifies the code. I took that opportunity
to slide in an address space parameter into the accessors which allows to
have sets of accessors for single page size and multi page size
configurations.