From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756014AbXD0PqG (ORCPT ); Fri, 27 Apr 2007 11:46:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756016AbXD0PqF (ORCPT ); Fri, 27 Apr 2007 11:46:05 -0400 Received: from atlrel9.hp.com ([156.153.255.214]:44731 "EHLO atlrel9.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756014AbXD0PqC (ORCPT ); Fri, 27 Apr 2007 11:46:02 -0400 Message-ID: <463219CD.5040203@hp.com> Date: Fri, 27 Apr 2007 11:42:05 -0400 From: Peter Keilty User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041209) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Walker Cc: linux-ia64@vger.kernel.org, John Stultz , Eric Whitney , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ia64: convert to use clocksource code References: <20070426202632.23343.54944.sendpatchset@rambler.zko.hp.com> <1177621673.12796.121.camel@imap.mvista.com> <46320ACD.6090704@hp.com> <1177688158.12796.125.camel@imap.mvista.com> In-Reply-To: <1177688158.12796.125.camel@imap.mvista.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Daniel Walker wrote: >On Fri, 2007-04-27 at 10:38 -0400, Peter Keilty wrote: > > >>Daniel Walker wrote: >> >> >> >>>On Thu, 2007-04-26 at 16:26 -0400, Peter Keilty wrote: >>> >>> >>> >>> >>> >>>>+ .mask = (1LL << 40) - 1, >>>>+ .mult = 0, /*to be caluclated*/ >>>>+ .shift = 16, >>>>+ .is_continuous = 1, >>>>}; >>>> >>>> >>>> >>>> >>>You should use CLOCKSOURCE_MASK() here .. >>> >>> >>> >>> >>> >>It is correct in patch 3, I believe. >> >> > >There's another spot that should use CLOCKSOURE_MASK() in the hpet I >think . > > Correct that was change in patch 3 also. > > >>> >>> >>> >>> >>>>diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h >>>>index daa4940..a20b4d6 100644 >>>>--- a/include/linux/clocksource.h >>>>+++ b/include/linux/clocksource.h >>>>@@ -61,6 +61,9 @@ struct clocksource { >>>> u32 shift; >>>> unsigned long flags; >>>> cycle_t (*vread)(void); >>>>+#ifdef CONFIG_IA64 >>>>+ void *fsys_mmio_ptr; /* used by fsyscall asm code */ >>>>+#endif >>>> >>>> >>>> >>>> >>>Could you explain in detail why this is needed? >>> >>> >>> >>> >>This ptr is needed to hold the mmio address to read the cycle value. >>The fast ia64 path utilizies a special gate page which can allow user >>code to execute small amount of kernel code, normal calling a function >>not done and so the address is need. The fast syscall path executes on >>user stack, between user/kernel state. And if the the fast path has to >>fallback >>to the slow syscall code the vread will be needed and used. >> >> > >There is a read(), and a vread() did you modify the slow syscall path to >use the vread()? > > I miss type, read(). >Daniel > > >