From: Valentin Kleibel <valentin@vrvis.at>
To: Justin Sanders <jsanders.devel@gmail.com>
Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk, ed.cashin@acm.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] aoe: clean device rq_list in aoedev_downdev()
Date: Tue, 17 Jun 2025 13:55:19 +0200 [thread overview]
Message-ID: <46323554-0ccf-4fce-855f-84e06f8fc7b3@vrvis.at> (raw)
In-Reply-To: <20250610170600.869-1-jsanders.devel@gmail.com>
On 10/06/2025 19.05, Justin Sanders wrote:
> An aoe device's rq_list contains accepted block requests that are
> waiting to be transmitted to the aoe target. This queue was added as
> part of the conversion to blk_mq. However, the queue was not cleaned out
> when an aoe device is downed which caused blk_mq_freeze_queue() to sleep
> indefinitely waiting for those requests to complete, causing a hang. This
> fix cleans out the queue before calling blk_mq_freeze_queue().
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=212665
> Fixes: 3582dd291788 ("aoe: convert aoeblk to blk-mq")
> Signed-off-by: Justin Sanders <jsanders.devel@gmail.com>
Thank you very much for the patches to fix this issue.
We have tested them in our environment and can confirm that they work as
expected.
Tested-By: Valentin Kleibel <valentin@vrvis.at>
Best Regards,
Valentin
next prev parent reply other threads:[~2025-06-17 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 17:05 [PATCH 1/2] aoe: clean device rq_list in aoedev_downdev() Justin Sanders
2025-06-10 17:06 ` [PATCH 2/2] aoe: defer rexmit timer downdev work to workqueue Justin Sanders
2025-06-17 11:55 ` Valentin Kleibel [this message]
2025-06-17 12:12 ` [PATCH 1/2] aoe: clean device rq_list in aoedev_downdev() Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46323554-0ccf-4fce-855f-84e06f8fc7b3@vrvis.at \
--to=valentin@vrvis.at \
--cc=axboe@kernel.dk \
--cc=ed.cashin@acm.org \
--cc=jsanders.devel@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox