public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Giridhar Pemmasani <pgiri@yahoo.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Allow __vmalloc with GFP_ATOMIC
Date: Sat, 28 Apr 2007 14:13:56 +1000	[thread overview]
Message-ID: <4632CA04.6040706@yahoo.com.au> (raw)
In-Reply-To: <539764.53941.qm@web32409.mail.mud.yahoo.com>

Giridhar Pemmasani wrote:
> Until 2.6.19, __vmalloc with GFP_ATOMIC was possible, but __get_vm_area_node
> would allocate the node itself with GFP_KERNEL, causing a warning. In 2.6.19,
> this was "fixed" by using the same flags that were passed to __vmalloc also
> in __get_vm_area_node. However, __get_vm_area_node does
> BUG_ON(in_interrupt()) now, since vmlist_lock is obtained without disabling
> bottom-half's. The patch below uses bh disabled lock for vmlist_lock, so that
> __vmalloc can be used in interrupt context.
> 
> In 2.6.21, __vmalloc with GFP_ATOMIC is used by arch/um/kernel/process.c;
> __vmalloc is also used in ntfs, xfs, but it is not clear to me if they use it
> with GFP_ATOMIC or GFP_KERNEL.
> 
> Thanks,
> Giri

Hi Giri,

I'm sure I've read the reason for this one before, but when you do patches
like these, can you include that reason in the changelog please?

Thanks,
Nick

-- 
SUSE Labs, Novell Inc.

  reply	other threads:[~2007-04-28  4:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-28  4:03 [PATCH] Allow __vmalloc with GFP_ATOMIC Giridhar Pemmasani
2007-04-28  4:13 ` Nick Piggin [this message]
2007-04-28  5:48   ` Giridhar Pemmasani
2007-04-28  7:52 ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4632CA04.6040706@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pgiri@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox