From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andi Kleen <ak@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: fix PSE pagetable construction
Date: Sat, 28 Apr 2007 07:30:03 -0700 [thread overview]
Message-ID: <46335A6B.7070504@goop.org> (raw)
In-Reply-To: <200704281225.15849.ak@suse.de>
Andi Kleen wrote:
>> ===================================================================
>> --- a/arch/i386/mm/hugetlbpage.c
>> +++ b/arch/i386/mm/hugetlbpage.c
>> @@ -183,6 +183,7 @@ follow_huge_addr(struct mm_struct *mm, u
>> return page;
>> }
>>
>> +#undef pmd_huge
>> int pmd_huge(pmd_t pmd)
>>
>
> Please handle that in the headers or rename it
>
Well, can I just get rid of the whole chunk of code that it's in? It's
only for "testing".
J
next prev parent reply other threads:[~2007-04-28 14:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-28 2:15 [PATCH] x86: fix PSE pagetable construction Jeremy Fitzhardinge
2007-04-28 5:56 ` Eric W. Biederman
2007-04-28 6:30 ` Jeremy Fitzhardinge
2007-04-28 6:39 ` Eric W. Biederman
2007-04-28 10:29 ` Andi Kleen
2007-04-28 14:28 ` Jeremy Fitzhardinge
2007-04-28 15:27 ` Eric W. Biederman
2007-04-28 23:25 ` Jeremy Fitzhardinge
2007-04-28 17:23 ` Eric W. Biederman
2007-04-28 18:03 ` Andi Kleen
2007-04-28 18:32 ` Eric W. Biederman
2007-04-28 10:25 ` Andi Kleen
2007-04-28 14:30 ` Jeremy Fitzhardinge [this message]
2007-04-28 14:55 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46335A6B.7070504@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox