* [DOC] Fix wrong identifier name in Documentation/driver-model/devres.txt
@ 2007-04-26 7:26 Rolf Eike Beer
2007-04-26 7:44 ` Tejun Heo
2007-04-28 15:14 ` Jeff Garzik
0 siblings, 2 replies; 6+ messages in thread
From: Rolf Eike Beer @ 2007-04-26 7:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Tejun Heo, Jeff Garzik
Above and below we talk about my_midlayer_create_something, I assume that is
also meant here.
Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
---
commit bb5f6ef5bbbdc0233690fe3ba6d5787a6aab9b33
tree cd948e03b4add89be6e648d31b7778c64a51e8d2
parent 64aa7c3136258d3abc76354b5f83b9a9575169c0
author Rolf Eike Beer <eike-kernel@sf-tec.de> Thu, 26 Apr 2007 09:23:39 +0200
committer Rolf Eike Beer <eike-kernel@sf-tec.de> Thu, 26 Apr 2007 09:23:39 +0200
Documentation/driver-model/devres.txt | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/driver-model/devres.txt b/Documentation/driver-model/devres.txt
index 5163b85..6c8d8f2 100644
--- a/Documentation/driver-model/devres.txt
+++ b/Documentation/driver-model/devres.txt
@@ -182,7 +182,7 @@ For example, you can do something like the following.
...
- devres_close_group(dev, my_midlayer_something);
+ devres_close_group(dev, my_midlayer_create_something);
return 0;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [DOC] Fix wrong identifier name in Documentation/driver-model/devres.txt
2007-04-26 7:26 [DOC] Fix wrong identifier name in Documentation/driver-model/devres.txt Rolf Eike Beer
@ 2007-04-26 7:44 ` Tejun Heo
2007-04-28 15:14 ` Jeff Garzik
1 sibling, 0 replies; 6+ messages in thread
From: Tejun Heo @ 2007-04-26 7:44 UTC (permalink / raw)
To: Rolf Eike Beer; +Cc: linux-kernel, Jeff Garzik
Rolf Eike Beer wrote:
> Above and below we talk about my_midlayer_create_something, I assume that is
> also meant here.
>
> Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
Acked-by: Tejun Heo <htejun@gmail.com>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [DOC] Fix wrong identifier name in Documentation/driver-model/devres.txt
2007-04-26 7:26 [DOC] Fix wrong identifier name in Documentation/driver-model/devres.txt Rolf Eike Beer
2007-04-26 7:44 ` Tejun Heo
@ 2007-04-28 15:14 ` Jeff Garzik
2007-04-29 7:50 ` Tejun Heo
1 sibling, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2007-04-28 15:14 UTC (permalink / raw)
To: Rolf Eike Beer; +Cc: linux-kernel, Tejun Heo, Greg KH
Rolf Eike Beer wrote:
> Above and below we talk about my_midlayer_create_something, I assume that is
> also meant here.
>
> Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
>
> ---
> commit bb5f6ef5bbbdc0233690fe3ba6d5787a6aab9b33
> tree cd948e03b4add89be6e648d31b7778c64a51e8d2
> parent 64aa7c3136258d3abc76354b5f83b9a9575169c0
> author Rolf Eike Beer <eike-kernel@sf-tec.de> Thu, 26 Apr 2007 09:23:39 +0200
> committer Rolf Eike Beer <eike-kernel@sf-tec.de> Thu, 26 Apr 2007 09:23:39 +0200
>
> Documentation/driver-model/devres.txt | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/driver-model/devres.txt b/Documentation/driver-model/devres.txt
> index 5163b85..6c8d8f2 100644
> --- a/Documentation/driver-model/devres.txt
> +++ b/Documentation/driver-model/devres.txt
> @@ -182,7 +182,7 @@ For example, you can do something like the following.
>
> ...
>
> - devres_close_group(dev, my_midlayer_something);
> + devres_close_group(dev, my_midlayer_create_something);
> return 0;
hmmm.
Now that devres is in the kernel, I don't think I am the best person to
merge these sort of patches. Certainly I can, and I know the code from
my original review and subsequent usage, but I think the patch is more
appropriate for Greg, going through normal maintainership channels.
IOW, I think devres is too generic to be queued via libata-dev.git.
Tejun, comments?
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [DOC] Fix wrong identifier name in Documentation/driver-model/devres.txt
2007-04-28 15:14 ` Jeff Garzik
@ 2007-04-29 7:50 ` Tejun Heo
2007-04-30 6:41 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Tejun Heo @ 2007-04-29 7:50 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Rolf Eike Beer, linux-kernel, Greg KH
Jeff Garzik wrote:
> Now that devres is in the kernel, I don't think I am the best person to
> merge these sort of patches. Certainly I can, and I know the code from
> my original review and subsequent usage, but I think the patch is more
> appropriate for Greg, going through normal maintainership channels.
>
> IOW, I think devres is too generic to be queued via libata-dev.git.
>
> Tejun, comments?
I don't have problem either way. If it's okay with Greg, I'll queue
future devres updates through Greg.
BTW, converting network drivers to devres is on my ever-growing todo
list and when those are done they will go through you, Jeff. :-)
--
tejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [DOC] Fix wrong identifier name in Documentation/driver-model/devres.txt
2007-04-29 7:50 ` Tejun Heo
@ 2007-04-30 6:41 ` Greg KH
2007-05-01 9:00 ` [PATCH] DOC: " Tejun Heo
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2007-04-30 6:41 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jeff Garzik, Rolf Eike Beer, linux-kernel
On Sun, Apr 29, 2007 at 04:50:29PM +0900, Tejun Heo wrote:
> Jeff Garzik wrote:
> > Now that devres is in the kernel, I don't think I am the best person to
> > merge these sort of patches. Certainly I can, and I know the code from
> > my original review and subsequent usage, but I think the patch is more
> > appropriate for Greg, going through normal maintainership channels.
> >
> > IOW, I think devres is too generic to be queued via libata-dev.git.
> >
> > Tejun, comments?
>
> I don't have problem either way. If it's okay with Greg, I'll queue
> future devres updates through Greg.
It's fine with me, send them on :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] DOC: Fix wrong identifier name in Documentation/driver-model/devres.txt
2007-04-30 6:41 ` Greg KH
@ 2007-05-01 9:00 ` Tejun Heo
0 siblings, 0 replies; 6+ messages in thread
From: Tejun Heo @ 2007-05-01 9:00 UTC (permalink / raw)
To: Greg KH; +Cc: Jeff Garzik, Rolf Eike Beer, linux-kernel
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
Above and below we talk about my_midlayer_create_something, I assume that is
also meant here.
Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
Signed-off-by: Tejun Heo <htejun@gmail.com>
diff --git a/Documentation/driver-model/devres.txt b/Documentation/driver-model/devres.txt
index 5163b85..6c8d8f2 100644
--- a/Documentation/driver-model/devres.txt
+++ b/Documentation/driver-model/devres.txt
@@ -182,7 +182,7 @@ For example, you can do something like t
...
- devres_close_group(dev, my_midlayer_something);
+ devres_close_group(dev, my_midlayer_create_something);
return 0;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-05-01 9:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-26 7:26 [DOC] Fix wrong identifier name in Documentation/driver-model/devres.txt Rolf Eike Beer
2007-04-26 7:44 ` Tejun Heo
2007-04-28 15:14 ` Jeff Garzik
2007-04-29 7:50 ` Tejun Heo
2007-04-30 6:41 ` Greg KH
2007-05-01 9:00 ` [PATCH] DOC: " Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox