From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946848AbXD3WGc (ORCPT ); Mon, 30 Apr 2007 18:06:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946847AbXD3WGc (ORCPT ); Mon, 30 Apr 2007 18:06:32 -0400 Received: from mx1.redhat.com ([66.187.233.31]:47549 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946843AbXD3WGa (ORCPT ); Mon, 30 Apr 2007 18:06:30 -0400 Message-ID: <4636685E.2010701@redhat.com> Date: Mon, 30 Apr 2007 18:06:22 -0400 From: Chuck Ebbert Organization: Red Hat User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Jeff Garzik CC: linux-ide@vger.kernel.org, LKML Subject: Re: [git patches] libata updates References: <20070429161542.GA12501@havoc.gtf.org> <46364901.4000907@redhat.com> <46364C04.4050208@garzik.org> In-Reply-To: <46364C04.4050208@garzik.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jeff Garzik wrote: > Chuck Ebbert wrote: >> Jeff Garzik wrote: >>> Jeff Garzik (8): >>> libata/IDE: remove combined mode quirk >> >> You can't just remove the "combined_mode=" kernel parameter or >> every Linux user who uses that will get an unbootable kernel >> with no good way of diagnosing the problem. It should still >> be accepted and just print a warning. > > No, most modern distros will simply Just Work(tm) due to mount by label, > udev, and similar gadgets. > > As long as you have at least one (if not both) ATA drivers, you have a > kernel that will boot your hardware. And by definition those using > combined_mode= do indeed have the necessary drivers. OK, this is a kernel parameter and should be fine. But you can't remove *module* parameters for drivers needed for booting or the initrd will fail to load the module with "unknown parameter" and users can't boot.