Re: [PATCH] [30/30] x86_64: Add missing !X86_PAE dependincy to the 2G/2G split.

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

From: Eric Dumazet <dada1@cosmosbay.com>
To: Andi Kleen <ak@suse.de>
Cc: ebiederm@xmission.com, patches@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [30/30] x86_64: Add missing !X86_PAE dependincy to the 2G/2G split.
Date: Tue, 01 May 2007 06:26:23 +0200	[thread overview]
Message-ID: <4636C16F.204@cosmosbay.com> (raw)
In-Reply-To: <20070501035829.1C93D13CAF@wotan.suse.de>

[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]

Andi Kleen a écrit :
> From: ebiederm@xmission.com
> 
> When in PAE mode we require that the user kernel divide to be
> on a 1G boundary.  The 2G/2G split does not have that property
> so require !X86_PAE
> 
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
> ---
>  arch/i386/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
> index 1a94a73..80003de 100644
> --- a/arch/i386/Kconfig
> +++ b/arch/i386/Kconfig
> @@ -570,6 +570,7 @@ choice
>  		depends on !HIGHMEM
>  		bool "3G/1G user/kernel split (for full 1G low memory)"
>  	config VMSPLIT_2G
> +		depends on !X86_PAE
>  		bool "2G/2G user/kernel split"
>  	config VMSPLIT_1G
>  		bool "1G/3G user/kernel split"

Hum... We lose a usefull 2G/2G split. Should'nt we use a patch to change 
PAGE_OFFSET to 0x8000000 instead of 0x78000000 and keep 2G/2G split ?

Maybe the following patch is better ?

[PATCH] i386 : Adjust CONFIG_PAGE_OFFSET in case of 2G/2G split and X86_PAE

When in PAE mode we require that the user kernel divide to be
on a 1G boundary.  We must therefore make sure PAGE_OFFSET is correctlty 
defined in the 2G/2G split and PAE mode.

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>

[-- Attachment #2: i386_CONFIG_PAGE_OFFSET.patch --]
[-- Type: text/plain, Size: 414 bytes --]

diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
index 53d6237..32356f2 100644
--- a/arch/i386/Kconfig
+++ b/arch/i386/Kconfig
@@ -578,7 +578,8 @@ endchoice
 config PAGE_OFFSET
 	hex
 	default 0xB0000000 if VMSPLIT_3G_OPT
-	default 0x78000000 if VMSPLIT_2G
+	default 0x78000000 if (VMSPLIT_2G && !X86_PAE)
+	default 0x80000000 if (VMSPLIT_2G && X86_PAE)
 	default 0x40000000 if VMSPLIT_1G
 	default 0xC0000000

next prev parent reply	other threads:[~2007-05-01  4:26 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-01  3:57 [PATCH] [0/30] x86 candidate patches for review VII: VDSO, CPUID, NMI watchdog, MCE, misc Andi Kleen
2007-05-01  3:57 ` [PATCH] [1/30] x86_64: Dynamically adjust machine check interval Andi Kleen
2007-05-01  3:57 ` [PATCH] [2/30] x86_64: set node_possible_map at runtime - try 2 Andi Kleen
2007-05-01  3:58 ` [PATCH] [3/30] i386: Clean up NMI watchdog code Andi Kleen
2007-05-01  3:58 ` [PATCH] [4/30] x86_64: Use the 32bit wd_ops for 64bit too Andi Kleen
2007-05-01  3:58 ` [PATCH] [5/30] x86_64: Define IGNORE_IOCTL() macro for compat_ioctls Andi Kleen
2007-05-01  3:58 ` [PATCH] [6/30] x86_64: Shut up 32bit emulation for SIOCGIFCOUNT Andi Kleen
2007-05-01  3:58 ` [PATCH] [7/30] x86_64: Avoid overflows during apic timer calibration Andi Kleen
2007-05-01  3:58 ` [PATCH] [8/30] x86_64: Add vDSO for x86-64 with gettimeofday/clock_gettime/getcpu Andi Kleen
2007-05-01  5:57   ` Jeremy Fitzhardinge
2007-05-01  7:23     ` Andi Kleen
2007-05-01  8:00       ` Jeremy Fitzhardinge
2007-05-01  3:58 ` [PATCH] [9/30] x86_64: Use symbolic CPU features in early CPUID check Andi Kleen
2007-05-01  3:58 ` [PATCH] [10/30] x86_64: Drop -traditional for arch/x86_64/boot Andi Kleen
2007-05-01  3:58 ` [PATCH] [11/30] i386: Drop -traditional in arch/i386/boot Andi Kleen
2007-05-01  3:58 ` [PATCH] [12/30] i386: Verify important CPUID bits in real mode Andi Kleen
2007-05-01  3:58 ` [PATCH] [13/30] i386: Evaluate constant cpu features at runtime Andi Kleen
2007-05-01  3:58 ` [PATCH] [14/30] i386: Implement alternative_io for i386 Andi Kleen
2007-05-01  3:58 ` [PATCH] [15/30] i386: Implement X86_FEATURE_SYNC_RDTSC on i386 Andi Kleen
2007-05-01  3:58 ` [PATCH] [16/30] i386: Add X86_FEATURE_RDTSCP Andi Kleen
2007-05-01  3:58 ` [PATCH] [17/30] x86: Use RDTSCP for synchronous get_cycles if possible Andi Kleen
2007-05-01  3:58 ` [PATCH] [18/30] x86_64: Don't enable NUMA for a single node in K8 NUMA scanning Andi Kleen
2007-05-01  3:58 ` [PATCH] [19/30] i386: Little cleanups in smpboot.c Andi Kleen
2007-05-01  3:58 ` [PATCH] [20/30] i386: Remove copy_*_user BUG_ONs for (size < 0) Andi Kleen
2007-05-01  3:58 ` [PATCH] [21/30] x86_64: Print type and size correctly for unknown compat ioctls Andi Kleen
2007-05-01  3:58 ` [PATCH] [22/30] x86_64: Remove CONFIG_REORDER Andi Kleen
2007-05-01  3:58 ` [PATCH] [23/30] x86_64: Share identical video.S between i386 and x86-64 Andi Kleen
2007-05-01  3:58 ` [PATCH] [24/30] x86_64: Shut up warnings for vfat compat ioctls on other file systems Andi Kleen
2007-05-01 15:45   ` Chuck Ebbert
2007-05-02 10:46     ` Andi Kleen
2007-05-01  3:58 ` [PATCH] [25/30] x86_64: Fix allnoconfig error in genapic_flat.c Andi Kleen
2007-05-01  3:58 ` [PATCH] [26/30] i386: Drop noisy e820 debugging printks Andi Kleen
2007-05-01  3:58 ` [PATCH] [27/30] i386: white space fixes in i387.h Andi Kleen
2007-05-01  3:58 ` [PATCH] [28/30] i386: avoid redundant preempt_disable in __unlazy_fpu Andi Kleen
2007-05-01  3:58 ` [PATCH] [29/30] x86_64: Don't exclude asm-offsets.c in Documentation/dontdiff Andi Kleen
2007-05-01  3:58 ` [PATCH] [30/30] x86_64: Add missing !X86_PAE dependincy to the 2G/2G split Andi Kleen
2007-05-01  4:26   ` Eric Dumazet [this message]
2007-05-01  6:21     ` Andi Kleen
2007-05-01 13:01       ` Bill Irwin
2007-05-01 13:49         ` Mark Lord
2007-05-01 15:51         ` Eric Dumazet
2007-05-01 17:00           ` Bill Irwin
2007-05-01 17:17             ` Eric W. Biederman
2007-05-01 20:41               ` Eric Dumazet
2007-05-02  9:38             ` Andi Kleen
2007-05-01  4:37   ` William Lee Irwin III
2007-05-01  4:57     ` Eric Dumazet
2007-05-01  5:11       ` William Lee Irwin III
2007-05-01  5:35     ` Eric W. Biederman
2007-05-01 13:32     ` Mark Lord
2007-05-01 14:17       ` William Lee Irwin III
2007-05-01 14:20         ` Mark Lord

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:53d6237 dfblob:32356f2 )
 OR (
bs:"Re: [PATCH] [30/30] x86_64: Add missing !X86_PAE dependincy to the 2G/2G split." )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4636C16F.204@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=ak@suse.de \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@x86-64.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox