From: Tejun Heo <htejun@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jeff@garzik.org, linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] libata-sff: Undo bug introduced with pci_iomap changes
Date: Tue, 01 May 2007 17:30:47 +0200 [thread overview]
Message-ID: <46375D27.3060901@gmail.com> (raw)
In-Reply-To: <20070501125327.52dd92e4@the-village.bc.nu>
Hello, Alan.
Alan Cox wrote:
> If you have a controller with one channel disabled and unmapped the new
> iomap code blindly tries to iomap unconfigured BARs. Later on the code
> does the right thing and checks for unmapped bars but it is done in the
> wrong order
>
> Reorder the checks and make the iomap conditional
>
> Tejun: I think the code below is now correct but would appreciate you
> giving it a review.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
Acked-by: Tejun Heo <htejun@gmail.com>
Yeap, the patch looks good. I got tunnel visioned while converting to
iomap and mechanically mapped IO BAR access to iomap. Thanks for
catching this. This is already fixed in #upstream while converting to
new-init-model (the code is in ata_pci_init_native_host() and does about
the same thing as your patch does), so I think this patch is only needed
for -stable. Cc'ing stable team. The original patch can be reached at...
http://article.gmane.org/gmane.linux.kernel/523335/raw
Thanks.
--
tejun
prev parent reply other threads:[~2007-05-01 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 11:53 [PATCH] libata-sff: Undo bug introduced with pci_iomap changes Alan Cox
2007-05-01 15:30 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46375D27.3060901@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox