linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: Michel Lespinasse <walken@zoy.org>,
	linux-kernel@vger.kernel.org, Dave Jones <davej@redhat.com>,
	Jeb Cramer <cramerj@intel.com>,
	John Ronciak <john.ronciak@intel.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: Re: 24 lost ticks with 2.6.20.10 kernel
Date: Tue, 01 May 2007 15:45:39 -0700	[thread overview]
Message-ID: <4637C313.8040002@intel.com> (raw)
In-Reply-To: <4637C227.5040108@redhat.com>

Chuck Ebbert wrote:
> Kok, Auke wrote:
>> Michel Lespinasse wrote:
>>> (I've added the E1000 maintainers to the thread as I found the issue
>>> seems to go away after I compile out that driver. For reference, I was
>>> trying to figure out why I lose exactly 24 ticks about every two
>>> seconds, as shown with report_lost_ticks. This is with a DQ965GF
>>> motherboard with onboard E1000).
>> that's perfectly likely. The main issue is that we read the hardware
>> stats every two seconds and that can consume quite some time. It's
>> strange that you are losing that many ticks IMHO, but losing one or two
>> might very well be.
>>
>> We've been playing with all sorts of solutions to this problem and
>> haven't come up with a way to reduce the load of the system reading HW
>> stats, and it remains the most likely culprit, allthough I don't rule
>> out clean routines just yet. This could very well be exaggerated at
>> 100mbit speeds as well, I never looked at that.
>>
>> I've had good results with 2.6.21.1 (even running tickless :)) on these
>> NICs. Have you tried that yet?
> 
> Maybe this could fix it in 2.6.20? (went into 2.6.21)

well, that hasn't got anything to do with stats, but is part of the clean_tx/rx 
codepath. I personally don't get any lost_ticks so I can't reproduce, but that 
was why I was hinting that you can try it for us ;)

codewise, the patch below makes our cleanup routine spend _more_ time, instead 
of less, which is why I think it's not the cause nor fix.

Auke

> 
> --------------------------------------------------------------------------
> 
> Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=46fcc86dd71d70211e965102fb69414c90381880
> Commit:     46fcc86dd71d70211e965102fb69414c90381880
> Parent:     2b858bd02ffca71391161f5709588fc70da79531
> Author:     Linus Torvalds <torvalds@woody.linux-foundation.org>
> AuthorDate: Thu Apr 19 18:21:01 2007 -0700
> Committer:  Linus Torvalds <torvalds@woody.linux-foundation.org>
> CommitDate: Thu Apr 19 18:21:01 2007 -0700
> 
>     Revert "e1000: fix NAPI performance on 4-port adapters"
>     
>     This reverts commit 60cba200f11b6f90f35634c5cd608773ae3721b7.  It's been
>     linked to lockups of the e1000 hardware, see for example
>     
>     	https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229603
>     
>     but it's likely that the commit itself is not really introducing the
>     bug, but just allowing an unrelated problem to rear its ugly head (ie
>     one current working theory is that the code exposes us to a hardware
>     race condition by decreasing the amount of time we spend in each NAPI
>     poll cycle).
>     
>     We'll revert it until root cause is known.  Intel has a repeatable
>     reproduction on two different machines and bus traces of the hardware
>     doing something bad.
>     

  reply	other threads:[~2007-05-01 22:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-01 13:07 24 lost ticks with 2.6.20.10 kernel Michel Lespinasse
2007-05-01 15:34 ` Chuck Ebbert
2007-05-01 21:49   ` Michel Lespinasse
2007-05-01 22:08     ` Kok, Auke
2007-05-01 22:41       ` Chuck Ebbert
2007-05-01 22:45         ` Kok, Auke [this message]
2007-05-02  0:06       ` Lee Revell
2007-05-02  8:41       ` Michel Lespinasse
2007-05-02 16:07         ` Kok, Auke
2007-05-02 18:14         ` Kok, Auke
2007-05-03  6:27           ` e1000 issue on DQ965GF board (was 24 lost ticks with 2.6.20.10 kernel) Michel Lespinasse
2007-05-03 15:36             ` Kok, Auke
2007-05-03 15:56               ` Allan, Bruce W
2007-05-04 18:25             ` Kok, Auke
2007-05-04 21:15               ` Michel Lespinasse
2007-05-02 12:54 ` 24 lost ticks with 2.6.20.10 kernel Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4637C313.8040002@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=cebbert@redhat.com \
    --cc=cramerj@intel.com \
    --cc=davej@redhat.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=walken@zoy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).