public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <lkml@rtr.ca>
To: Glauber de Oliveira Costa <gcosta@redhat.com>
Cc: ak@suse.de, akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove unnecessary irq disabling
Date: Tue, 01 May 2007 19:59:21 -0400	[thread overview]
Message-ID: <4637D459.2040502@rtr.ca> (raw)
In-Reply-To: <20070501213050.GD6119@redhat.com>

Glauber de Oliveira Costa wrote:
> RR asks us if it is really necessary to disable interrupts in
> setup_secondary_APIC_clock(). The answer is no, since setup_APIC_timer()
> starts by saving irq flags, which also disables them.
> 
> Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
> 
> --- a/arch/x86_64/kernel/apic.c
> +++ b/arch/x86_64/kernel/apic.c
> @@ -875,9 +875,7 @@ void __init setup_boot_APIC_clock (void)
>  
>  void __cpuinit setup_secondary_APIC_clock(void)
>  {
> -	local_irq_disable(); /* FIXME: Do we need this? --RR */
>  	setup_APIC_timer(calibration_result);
> -	local_irq_enable();
>  }
>  
>  void disable_APIC_timer(void)

Okay, I'll bite:  before the patch, this code would exit
with interrupts *enabled*, always.   Now it does not.

What does that break, or was it already broken and this fixes it?

Cheers

  reply	other threads:[~2007-05-01 23:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-01 21:30 [PATCH] Remove unnecessary irq disabling Glauber de Oliveira Costa
2007-05-01 23:59 ` Mark Lord [this message]
2007-05-02  4:44   ` Glauber de Oliveira Costa
2007-05-02  9:58     ` Andi Kleen
2007-05-02 12:27       ` Mark Lord
2007-05-02 16:13       ` Glauber de Oliveira Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4637D459.2040502@rtr.ca \
    --to=lkml@rtr.ca \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=gcosta@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox